Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest kustomize v5.6.0 to drop github.com/asaskevich/govalidator #129622

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Update to latest kustomize v5.6.0 to drop github.com/asaskevich/govalidator #129622

merged 2 commits into from
Jan 14, 2025

Conversation

dims
Copy link
Member

@dims dims commented Jan 14, 2025

/kind cleanup

Now we are in control of our own validation! yay!

xref: #128573

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@dims
Update to latest kustomize/v5.6.0
0d8a8fe 
Signed-off-by: Davanum Srinivas <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 14, 2025
@k8s-ci-robot k8s-ci-robot requested review from bart0sh, cheftako and a team January 14, 2025 18:36
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
@dims dims mentioned this pull request Jan 14, 2025
Closed
liggitt
liggitt reviewed Jan 14, 2025
View reviewed changes
go.mod Show resolved Hide resolved
@dims dims force-pushed the update-to-latest-kustomize-v5.6.0 branch from 078cd91 to ab68605 Compare January 14, 2025 19:19
@dims dims force-pushed the update-to-latest-kustomize-v5.6.0 branch from ab68605 to 9e24952 Compare January 14, 2025 20:09
@liggitt
Copy link
Member

liggitt commented Jan 14, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ad52bc1de633f916a554a533bcf7bf63c4949308

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims dims force-pushed the update-to-latest-kustomize-v5.6.0 branch from 9e24952 to 43d86c2 Compare January 14, 2025 20:53
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2025
@k8s-ci-robot k8s-ci-robot requested a review from liggitt January 14, 2025 20:54
@dims
Copy link
Member Author

dims commented Jan 14, 2025

@liggitt one more /lgtm please! fixing the linter hints

@liggitt
Copy link
Member

liggitt commented Jan 14, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 172a5fadf12c379ddb53ca9fdbb8988eeeb91eac

@dims
Copy link
Member Author

dims commented Jan 14, 2025

Successfully dropped github.com/asaskevich/govalidator shows up in stats.

--- /logs/artifacts/stats-base.txt	2025-01-14 20:12:04.669424517 +0000
+++ /logs/artifacts/stats.txt	2025-01-14 20:12:03.[9](https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/129622/check-dependency-stats/1879259657327874048#1:build-log.txt%3A9)89498414 +0000
@@ -1,6 +1,6 @@
-Direct Dependencies: 180 
-Transitive Dependencies: 329 
-Total Dependencies: 365 
+Direct Dependencies: 179 
+Transitive Dependencies: 328 
+Total Dependencies: 364 
 Max Depth Of Dependencies: 25 
 All dependencies:
 
@@ -[13](https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/129622/check-dependency-stats/1879259657327874048#1:build-log.txt%3A13)5,7 +135,6 @@
 github.com/antlr4-go/antlr/v4
 github.com/armon/circbuf
 github.com/armon/go-socks5
-github.com/asaskevich/govalidator
 github.com/aws/aws-sdk-go-v2
 github.com/aws/aws-sdk-go-v2/config
 github.com/aws/aws-sdk-go-v2/credentials

@k8s-ci-robot k8s-ci-robot merged commit 4281163 into kubernetes:master Jan 14, 2025
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 14, 2025
@dims dims mentioned this pull request Jan 15, 2025
Merged
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 16, 2025
@koba1t koba1t mentioned this pull request Jan 17, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart0sh bart0sh Awaiting requested review from bart0sh

@cheftako cheftako Awaiting requested review from cheftako

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
SIG Auth
Status: Closed / Done
SIG CLI
Status: Done
SIG Node: Dynamic Resource Allocation
Archived in project
SIG Node: code and documentation PRs
Status: Done
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
4 participants
@dims @liggitt @k8s-ci-robot @fedebongio