-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet: new kubelet config option for disabling group oom kill #126096
kubelet: new kubelet config option for disabling group oom kill #126096
Conversation
Skipping CI for Draft Pull Request. |
12311ee
to
6e7d175
Compare
6e7d175
to
00f4125
Compare
/lgtm Waiting for the test result: #126096 (comment) |
LGTM label has been added. Git tree hash: 02a3d5adf9dd34dc0ccf88bb694342898a14d5b9
|
8b0051c
to
51ff07f
Compare
/test pull-kubernetes-node-kubelet-serial-containerd I believe it will pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold for a nit on config field godoc to align with the yaml values users will specify, and one fix needed on the build tagging
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, liggitt, roycaihw, SergeyKanzhelev, utam0k, yujuhong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: utam0k <[email protected]>
51ff07f
to
4f909c1
Compare
/test pull-kubernetes-node-kubelet-serial-containerd |
@liggitt Thanks for your review. I've updated following your suggestions. |
/lgtm |
LGTM label has been added. Git tree hash: 1434b7ecb2606f35843efb840e693f15a8685a68
|
/test pull-kubernetes-unit |
What type of PR is this?
/kind feature
What this PR does / why we need it:
There is a difference in the OOM behavior between cgroup v1 and v2 by default. It's important to note that in cgroup v1 if one of the processes within a container is killed, the other processes will remain running. Ideally, we might want to align with cgroup v2's behavior, where all processes within a container are killed if an OOM event occurs. However, in reality, we need to maintain the behavior of cgroup v1 for the time being. Therefore, this pull request will introduce the
singleProcessOOMKill
flag to enable like cgroup v1's behavior in cgroup v2.Appearently, this workaround has already been discussed in a SIG-Node meeting.
#117793 (comment)
Which issue(s) this PR fixes:
Carry: #122813 by @tzneal
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: