Small changes to Services doc #12141
Conversation
gmarek
added
the
kind/documentation
|
GCE e2e build/test passed for commit 27585945d6a264083e23181814b3db449b61d76f. |
|
GCE e2e build/test failed for commit 47c283b6ce5685dd98a1842e752e0b65fc742731. |
|
cc @thockin |
| node of the cluster (the same port on each node) | ||
| * `LoadBalancer`: use a ClusterIP and a NodePort, but also ask the cloud | ||
| provider for a load balancer which forwards to the `Service` | ||
| discussed above. Choosing this value means that you want this to be the only |
There was a problem hiding this comment.
Your expansions here are good (thanks). I think the flow from "Service Types" to "External Services" to "Details about Service Types" is a bit awkward.
What if this restructured as:
## Publishing services - service types
For some parts of your app...
Every service has a type...
### Type NodePort
It still feels a little redundant to describe the types in fair detail only to follow up with a sub-chapter on each type half a page later...
gmarek
force-pushed
the
service_doc
branch
2 times, most recently
from
8d2f01f to
8fc74b9
Compare
|
GCE e2e build/test passed for commit 8d2f01f3858b0a42d77b40705b58a2c57205e9f6. |
|
@thockin commented, so assuming assigning is ok. |
|
GCE e2e build/test passed for commit 8fc74b976518432c0e001163b76fcb82577f4353. |
|
GCE e2e build/test passed for commit 7e02390bd70ab035d77b5ce44798cb94de70506b. |
|
@thockin PTAL |
|
Ping @thockin |
| node of the cluster (the same port on each node) | ||
| * `LoadBalancer`: use a ClusterIP and a NodePort, but also ask the cloud | ||
| provider for a load balancer which forwards to the `Service` | ||
| Kubernetes `ServiceTypes` allows you to specify what kind of service you want. |
There was a problem hiding this comment.
grammar and styling: "ServiceTypes allow ..." the type name is ServiceType (singular), but since you pluralize it, change "allows" to "allow". Yay English.
|
GCE e2e build/test passed for commit acf788b. |
|
@thockin PTAL |
|
Ping @thockin |
thockin
added
the
lgtm
|
lgtm |
Small changes to Services doc
I found this part of the doc really confusing and tried to make it a bit better.