Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #117751: Disable NewVolumeManagerReconstruction / SELinuxMountReadWriteOncePod feature gates #117752

Merged
merged 1 commit into from
May 5, 2023
Merged

Automated cherry pick of #117751: Disable NewVolumeManagerReconstruction / SELinuxMountReadWriteOncePod feature gates #117752

merged 1 commit into from
May 5, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 3, 2023 •
edited
Loading

Cherry pick of #117751 on release-1.27.

#117751: Disable NewVolumeManagerReconstruction feature gate

xref #117745

For details on the cherry pick process, see the cherry pick requests page.

Fixes a 1.27 regression by reverting NewVolumeManagerReconstruction and SELinuxMountReadWriteOncePod feature gates to disabled by default to resolve a regression of volume reconstruction on kubelet/node restart

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone May 3, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 3, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@dims
Copy link
Member

dims commented May 3, 2023

/kind bug
/sig storage
/triage accepted
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 3, 2023
@dims
Copy link
Member

dims commented May 3, 2023

cc @msau42 @xing-yang

@liggitt
Copy link
Member Author

liggitt commented May 3, 2023

/hold for storage ack

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
@aojea
Copy link
Member

aojea commented May 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: acd68764d4892081ff09e0f19548b06855ab6e5d

@jeremyrickard
Copy link
Contributor

/test pull-kubernetes-unit-go-compatibility

@liggitt liggitt changed the title Automated cherry pick of #117751: Disable NewVolumeManagerReconstruction feature gate Automated cherry pick of #117751: Disable NewVolumeManagerReconstruction / SELinuxMountReadWriteOncePod feature gates May 4, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@k8s-ci-robot k8s-ci-robot requested a review from aojea May 4, 2023 13:40
@liggitt
Copy link
Member Author

liggitt commented May 4, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023
@liggitt liggitt force-pushed the automated-cherry-pick-of-#117751-upstream-release-1.27 branch from 678dd34 to e0fffe6 Compare May 4, 2023 17:39
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2023
@liggitt liggitt force-pushed the automated-cherry-pick-of-#117751-upstream-release-1.27 branch from e0fffe6 to 7f9b3cb Compare May 4, 2023 20:43
@liggitt
Copy link
Member Author

liggitt commented May 5, 2023

/retest

@aojea
Copy link
Member

aojea commented May 5, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 403c0f23f51d1d4b3fe914c4834a5334c44c877f

@liggitt liggitt mentioned this pull request May 5, 2023
Closed
@liggitt
Copy link
Member Author

liggitt commented May 5, 2023

cc @kubernetes/release-managers

this is important to get in the next 1.27 patch release

@liggitt
Copy link
Member Author

liggitt commented May 5, 2023

pick only needed for 1.27 (which was when these gates changed state)

@dims
Copy link
Member

dims commented May 5, 2023

/assign @palnabarun @xmudrii

@msau42
Copy link
Member

msau42 commented May 5, 2023

/lgtm

xmudrii
xmudrii approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RelEng:
/lgtm
/approve

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 5, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ddd0316 into kubernetes:release-1.27 May 5, 2023
@liggitt liggitt mentioned this pull request May 6, 2023
Closed
@liggitt liggitt deleted the automated-cherry-pick-of-#117751-upstream-release-1.27 branch May 9, 2023 18:26
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Sep 9, 2023
@liggitt liggitt added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@aojea aojea Awaiting requested review from aojea

Assignees

@aojea aojea

@palnabarun palnabarun

@xmudrii xmudrii

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
8 participants
@liggitt @dims @aojea @k8s-ci-robot @jeremyrickard @msau42 @xmudrii @palnabarun