-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated selectorSpread #117720
Remove deprecated selectorSpread #117720
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/hold |
/hold cancel |
oh wait... but v1beta3 still could use the plugin, couldn't it? |
Yes, we didn't add it to the validations of invalid plugins. Wait for one more release? |
Yes, sorry for the confusion /hold |
Signed-off-by: kerthcet <[email protected]>
b6a6110
to
855b445
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kerthcet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 699905f65f71bf277dbb8318fa01c3f3a32e818e
|
/hold cancel |
@kerthcet: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
Changelog suggestion -ACTION REQUIRED: Kube-scheduler selectorSpread plugin is removed, please use podTopologySpread plugin instead.
+ACTION REQUIRED: the kube-scheduler `selectorSpread` plugin has been removed; please use the `podTopologySpread` plugin instead. Also, remember to get this change documented. |
Updated, and will follow the documentation. |
What type of PR is this?
/kind feature
/sig scheduling
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #108444
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: