Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #116428: Avoid metric lookup in Parallelizer.Until on every work piece #116441

Merged
merged 1 commit into from
Mar 11, 2023
Merged

Automated cherry pick of #116428: Avoid metric lookup in Parallelizer.Until on every work piece #116441

merged 1 commit into from
Mar 11, 2023

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Mar 9, 2023 •
edited by liggitt
Loading

Cherry pick of #116428 on release-1.26.

#116428: Avoid metric lookup in Parallelizer.Util on every work piece

For details on the cherry pick process, see the cherry pick requests page.

Fixed a 1.26 performance regression in scheduler caused by frequent metric lookup on critical code path.

Note for release manager: This only affects 1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Mar 9, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 9, 2023
@k8s-ci-robot k8s-ci-robot requested a review from denkensk March 9, 2023 21:11
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from sanposhiho March 9, 2023 21:11
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 9, 2023
@alculquicondor
Copy link
Member Author

/sig scheduling
/kind bug
/kind regression
/triage accepted
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 9, 2023
@sanposhiho
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d6e14b6d115a9fddb74194198138767a85828b7e

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 10, 2023
@Verolop Verolop removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 10, 2023
@mborsz
Copy link
Member

mborsz commented Mar 10, 2023

/retest

@mborsz
Copy link
Member

mborsz commented Mar 10, 2023

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team March 10, 2023 07:53
@alculquicondor
Copy link
Member Author

/retitle Automated cherry pick of #116428: Avoid metric lookup in Parallelizer.Until on every work piece

@k8s-ci-robot k8s-ci-robot changed the title Automated cherry pick of #116428: Avoid metric lookup in Parallelizer.Util on every work piece Automated cherry pick of #116428: Avoid metric lookup in Parallelizer.Until on every work piece Mar 10, 2023
@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 11, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 11, 2023
@Verolop
Copy link

Verolop commented Mar 11, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit b9e6999 into kubernetes:release-1.26 Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkensk denkensk Awaiting requested review from denkensk

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

Assignees

@Verolop Verolop

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
5 participants
@alculquicondor @k8s-ci-robot @sanposhiho @mborsz @Verolop