Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl cp command support passing full Windows path as target #102047

Closed

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented May 17, 2021

What type of PR is this?

/kind bug
/sig windows cli

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #77310
Fixes #101985

Special notes for your reviewer:

Does this PR introduce a user-facing change?

`kubectl cp` command support passing full Windows path as target

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 17, 2021
@k8s-ci-robot
Copy link
Contributor

@wzshiming: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl labels May 17, 2021
@k8s-ci-robot k8s-ci-robot requested review from dixudx and dougsland May 17, 2021 07:35
@odinuge
Copy link
Member

odinuge commented May 19, 2021

This looks like a duplicate of #78622 that was closed due to the general issues with kubectl cp (ref. kubernetes/enhancements#2381).

This issue is still bothering me tho, so I would definitely get this fixed.

Edit: Looks like that was partially fixed in another PR.

+1 on this one! 👍

@wzshiming
Copy link
Member Author

wzshiming commented May 19, 2021

This looks like a duplicate of #78622 that was closed due to the general issues with kubectl cp (ref. kubernetes/enhancements#2381).

This issue is still bothering me tho, so I would definitely get this fixed.

Yes. but the direction is different, only under Windows and full path.

@wzshiming
Copy link
Member Author

/assign @deads2k

@wzshiming
Copy link
Member Author

hi @deads2k could you have time to take a look

@eddiezane
Copy link
Member

/cc @soltysh

@k8s-ci-robot k8s-ci-robot requested a review from soltysh June 23, 2021 16:21
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
I'm introducing a new way of parsing paths, such that the local path is OS dependent and properly handled by golang, and the remote is always linux-base. Have a look if #94165 solves your problem.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wzshiming
To complete the pull request process, please ask for approval from deads2k after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 23, 2021
@k8s-ci-robot
Copy link
Contributor

@wzshiming: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2021
@wzshiming
Copy link
Member Author

Potentially fixed in #94165

@wzshiming wzshiming closed this Oct 25, 2021
@wzshiming wzshiming deleted the feat/kubectl-cp-windows-path branch October 25, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
7 participants