-
Notifications
You must be signed in to change notification settings - Fork 40.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubectl cp
command support passing full Windows path as target
#102047
kubectl cp
command support passing full Windows path as target
#102047
Conversation
@wzshiming: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue is still bothering me tho, so I would definitely get this fixed. Edit: Looks like that was partially fixed in another PR. +1 on this one! 👍 |
Yes. but the direction is different, only under Windows and full path. |
/assign @deads2k |
hi @deads2k could you have time to take a look |
/cc @soltysh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
I'm introducing a new way of parsing paths, such that the local path is OS dependent and properly handled by golang, and the remote is always linux-base. Have a look if #94165 solves your problem.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wzshiming The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@wzshiming: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Potentially fixed in #94165 |
What type of PR is this?
/kind bug
/sig windows cli
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #77310
Fixes #101985
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: