cross-build: PR 56036 causing cross build failure

[cblecker]

I1122 09:21:38.273] # k8s.io/kubernetes/cmd/kube-proxy/app
I1122 09:21:38.273] cmd/kube-proxy/app/server.go:221:36: too many arguments in call to NewProxyServer
I1122 09:21:38.273] 	have (*kubeproxyconfig.KubeProxyConfiguration, bool, bool, *"k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/runtime".Scheme, string)
I1122 09:21:38.273] 	want (*kubeproxyconfig.KubeProxyConfiguration, bool, *"k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/runtime".Scheme, string)

kubernetes/cmd/kube-proxy/app/server_windows.go

Line 49 in 4e2f5e2

func NewProxyServer(config *proxyconfigapi.KubeProxyConfiguration, cleanupAndExit bool, scheme *runtime.Scheme, master string) (*ProxyServer, error) {

#56036
https://k8s-testgrid.appspot.com/sig-release-misc#cross-build&graph-metrics=test-duration-minutes
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-cross-build/3958

---

cc: @kubernetes/sig-network-bugs @kubernetes/sig-network-test-failures @m1093782566 @thockin
/kind bug
/priority failing-test

[BenTheElder]

This is at least twice in a week we've had cross break due to a public method signature change not being brought to all platforms (#56002)
We should do: #55750

[thockin]

I'm lost - the PR in question adds an argument and fixes the call-site - what is broken?

[thockin]

Ahh, I see.

[thockin]

How did that PR get through, if it is so obviously broken on Cross?

[cblecker]

@thockin Cross build doesn't run 100% of the time as a pre-submit (because it takes so long), and it can't block. It's something sig-testing is tracking, but there isn't a quick fix yet.

[gnufied]

Looks like make cross was skipped for that PR:

"pull-kubernetes-cross Skipped"

not sure why yet.

[BenTheElder]

Cross runs when a file matching:
'^(build\/|hack\/lib\/)|(Makefile)|(.*_(windows|linux|osx|unsupported)(_test)?\.go)$'
changes, (which needs to be fixed, opening a test-infra issue to expand the regex), but also some files could have build tags without the file name matching (#55749)

Additionally cross is not blocking (kubernetes/test-infra#5584), the underlying bug should be fixed now though so once we get the fix in to k/k we can make it blocking when it does run.

[m1093782566]

I find @thockin has already sent a PR. Thanks!