Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kinder: update super-admin workflow for 1.30 #3012

Conversation

neolit123
Copy link
Member

xref #2414 (comment)

kubeadm 1.29 had code that creates the super-admin.conf file on upgrade. the same code is removed in kubeadm 1.30. Update the super-admin kinder workflow to reflect this change.

kubeadm 1.29 had code that creates the super-admin.conf file
on upgrade. the same code is removed in kubeadm 1.30.
Update the super-admin kinder workflow to reflect this change.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2024
@k8s-ci-robot k8s-ci-robot added area/kinder Issues to track work in the kinder tool approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 6, 2024
@neolit123 neolit123 requested review from pacoxu and removed request for chendave and SataQiu February 6, 2024 12:25
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 6, 2024
@neolit123 neolit123 added this to the v1.30 milestone Feb 6, 2024
@neolit123 neolit123 added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 6, 2024
@neolit123 neolit123 added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 6, 2024
@neolit123
Copy link
Member Author

self lgtm to try to fix CI

@neolit123 neolit123 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2024
@pacoxu
Copy link
Member

pacoxu commented Feb 7, 2024

/lgtm
miss this

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 49d7749 into kubernetes:main Feb 7, 2024
4 checks passed
@pacoxu
Copy link
Member

pacoxu commented Feb 7, 2024

https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-e2e-kubeadm-kinder-super-admin-latest/1755150059663527936/artifacts/task-09-post-upgrade-primary-cp-log.txt
last run still failed with this PR.

# admin.conf must exist, super-admin.conf must not exist as we deleted it after init
${CMD} test -f /etc/kubernetes/admin.conf || exit 1
${CMD} test -f /etc/kubernetes/super-admin.conf && exit 1

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-kubeadm-kinder-super-admin-latest/1755150059663527936

@pacoxu
Copy link
Member

pacoxu commented Feb 7, 2024

Last error was addressed, and this is a new one just after it.

grep: /etc/kubernetes/super-admin.conf: No such file or directory
Could not read certificate from <stdin>
Unable to load certificate
+ exit 1

The next line needs an update as well.

${CMD} grep 'client-certificate-data' /etc/kubernetes/super-admin.conf | awk '{print $2}' | base64 -d | openssl x509 -subject -noout | grep "subject=O = system:masters, CN = kubernetes-super-admin" || exit 1

@neolit123
Copy link
Member Author

right, i missed that one.
will send new PR a bit later.

@neolit123
Copy link
Member Author

Last error was addressed, and this is a new one just after it.

grep: /etc/kubernetes/super-admin.conf: No such file or directory
Could not read certificate from <stdin>
Unable to load certificate
+ exit 1

The next line needs an update as well.

${CMD} grep 'client-certificate-data' /etc/kubernetes/super-admin.conf | awk '{print $2}' | base64 -d | openssl x509 -subject -noout | grep "subject=O = system:masters, CN = kubernetes-super-admin" || exit 1

here is the PR
https://github.com/kubernetes/kubeadm/pull/3015/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants