Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patches for join/init/upgrade to the right place #2545

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Aug 12, 2021

The patches adding is inside if-else.

	if options.discoveryMode != TokenDiscovery && !(n == c.BootstrapControlPlane()) {

Move it out to fix the ci-kubernetes-e2e-kubeadm-kinder-patches-latest failure

Failure: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-kubeadm-kinder-patches-latest/1425293204315443200

See #2046 (comment)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Aug 12, 2021
@pacoxu pacoxu mentioned this pull request Aug 12, 2021
14 tasks
@pacoxu pacoxu force-pushed the kubeadm-patch-bug branch from 6735148 to 8d41475 Compare August 12, 2021 10:16
@pacoxu
Copy link
Member Author

pacoxu commented Aug 12, 2021

The test failed for

time="10:24:39" level=debug msg="using kubeadm config version v1beta3"
time="10:24:39" level=debug msg="Preparing kubeadm config v1beta3"
time="10:24:39" level=debug msg="Preparing dockerPatch for kubeadm config v1beta3"
time="10:24:39" level=debug msg="Preparing automaticCopyCertsPatches for kubeadm config v1beta3"
time="10:24:39" level=debug msg="Preparing patches directory for kubeadm config v1beta3"
time="10:24:39" level=debug msg="generated config:\napiVersion: kubeadm.k8s.io/v1beta3\ncontrolPlane:\n certificateKey: "0123456789012345678901234567890123456789012345678901234567890123"\n localAPIEndpoint:\n advertiseAddress: 172.17.0.5\n bindPort: 6443\ndiscovery:\n bootstrapToken:\n apiServerEndpoint: 172.17.0.7:6443\n token: abcdef.0123456789abcdef\n unsafeSkipCAVerification: true\nkind: JoinConfiguration\nmetadata:\n name: config\nnodeRegistration:\n criSocket: /var/run/dockershim.sock\n kubeletExtraArgs:\n node-ip: 172.17.0.5\npatches:\n directory: /kinder/patches\n"
time="10:24:39" level=debug msg="Running: [docker cp /tmp/kinder-pull-control-plane-2-139598552 kinder-pull-control-plane-2:/kind/kubeadm.conf]"

kinder-pull-control-plane-2:$ kubeadm join --config=/kind/kubeadm.conf --ignore-preflight-errors=Swap,SystemVerification,FileContent--proc-sys-net-bridge-bridge-nf-call-iptables --v=6
time="10:24:39" level=debug msg="Running: [docker exec kinder-pull-control-plane-2 kubeadm join --config=/kind/kubeadm.conf --ignore-preflight-errors=Swap,SystemVerification,FileContent--proc-sys-net-bridge-bridge-nf-call-iptables --v=6]"
I0812 10:24:39.719713 897 join.go:413] [preflight] found NodeName empty; using OS hostname as NodeName
I0812 10:24:39.719767 897 joinconfiguration.go:76] loading configuration from "/kind/kubeadm.conf"
W0812 10:24:39.720788 897 strict.go:55] error unmarshaling configuration schema.GroupVersionKind{Group:"kubeadm.k8s.io", Version:"v1beta3", Kind:"JoinConfiguration"}: error unmarshaling JSON: while decoding JSON: json: unknown field "metadata"

@pacoxu pacoxu force-pushed the kubeadm-patch-bug branch 2 times, most recently from f03d9c8 to c9d628f Compare August 12, 2021 11:42
@pacoxu
Copy link
Member Author

pacoxu commented Aug 12, 2021

time="11:47:56" level=debug msg="Running: [docker exec kinder-pull-control-plane-2 mkdir -p /kinder/patches]"
2021/08/12 11:47:56 open : no such file or directory

@pacoxu pacoxu force-pushed the kubeadm-patch-bug branch from c5bc67f to 11afc71 Compare August 12, 2021 13:17
@pacoxu pacoxu changed the title add patches for join/init/upgrade to the right place [WIP] add patches for join/init/upgrade to the right place Aug 12, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2021
@pacoxu pacoxu force-pushed the kubeadm-patch-bug branch from 11afc71 to b059f03 Compare August 12, 2021 13:44
@pacoxu pacoxu changed the title [WIP] add patches for join/init/upgrade to the right place add patches for join/init/upgrade to the right place Aug 12, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 12, 2021
@pacoxu pacoxu marked this pull request as draft August 12, 2021 14:02
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2021
@pacoxu pacoxu force-pushed the kubeadm-patch-bug branch from b059f03 to 450ac76 Compare August 13, 2021 04:48
@pacoxu pacoxu marked this pull request as ready for review August 13, 2021 04:52
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2021
@pacoxu pacoxu force-pushed the kubeadm-patch-bug branch 2 times, most recently from 550ddc7 to 524a57a Compare August 13, 2021 06:01
@pacoxu
Copy link
Member Author

pacoxu commented Aug 13, 2021

/cc neolit123

@k8s-ci-robot k8s-ci-robot requested a review from neolit123 August 13, 2021 06:55
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like github did to submit my last two comments.

…dm-patches` as the test prepares in this folder

Signed-off-by: Paco Xu <[email protected]>
@pacoxu pacoxu force-pushed the kubeadm-patch-bug branch from 524a57a to a7cfe06 Compare August 16, 2021 01:46
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2021
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit c804a0b into kubernetes:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants