-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add patches for join/init/upgrade to the right place #2545
Conversation
6735148
to
8d41475
Compare
The test failed for
|
f03d9c8
to
c9d628f
Compare
time="11:47:56" level=debug msg="Running: [docker exec kinder-pull-control-plane-2 mkdir -p /kinder/patches]" |
c5bc67f
to
11afc71
Compare
11afc71
to
b059f03
Compare
b059f03
to
450ac76
Compare
550ddc7
to
524a57a
Compare
/cc neolit123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like github did to submit my last two comments.
…dm-patches` as the test prepares in this folder Signed-off-by: Paco Xu <[email protected]>
524a57a
to
a7cfe06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The patches adding is inside if-else.
Move it out to fix the ci-kubernetes-e2e-kubeadm-kinder-patches-latest failure
Failure: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-kubeadm-kinder-patches-latest/1425293204315443200
See #2046 (comment)