Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ingress): fixed lint #2220

Closed
wants to merge 1 commit into from
Closed

Conversation

rohitphatak
Copy link
Contributor

What this PR does / why we need it: Lint fix in ingress doc

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 17, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohitphatak
Once this PR has been reviewed and has the lgtm label, please assign mrueg for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2023
@rohitphatak
Copy link
Contributor Author

/assign @CatherineF-dev

@CatherineF-dev
Copy link
Contributor

CatherineF-dev commented Oct 17, 2023

QQ: just curious, how did you resolve this issue? #2109 (comment)

@rohitphatak
Copy link
Contributor Author

QQ: just curious, how did you resolve this issue? #2109 (comment)

The lint error was due to an extra space in ingress-metrics.md. The same is corrected in PR. I am not seeing #2109 (comment) error in make lint.

@CatherineF-dev
Copy link
Contributor

It's fixed in #2219

Thx /close

@mrueg
Copy link
Member

mrueg commented Oct 18, 2023

/close
(needs to be on a new line)

@k8s-ci-robot
Copy link
Contributor

@mrueg: Closed this PR.

In response to this:

/close
(needs to be on a new line)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants