feat(ingress): updated test case

kubernetes · Sep 5, 2023 · a75883a · a75883a
1 parent 841f544
commit a75883a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/internal/store/ingress.go b/internal/store/ingress.go
@@ -162,9 +162,13 @@ func ingressMetricFamilies(allowAnnotationsList, allowLabelsList []string) []gen
 									Value:       1,
 								})
 							} else {
+								apiGroup := ""
+								if path.Backend.Resource.APIGroup != nil {
+									apiGroup = *path.Backend.Resource.APIGroup
+								}
 								ms = append(ms, &metric.Metric{
 									LabelKeys:   []string{"host", "path", "api_group", "kind", "name"},
-									LabelValues: []string{rule.Host, path.Path, *path.Backend.Resource.APIGroup, path.Backend.Resource.Kind, path.Backend.Resource.Name},
+									LabelValues: []string{rule.Host, path.Path, apiGroup, path.Backend.Resource.Kind, path.Backend.Resource.Name},
 									Value:       1,
 								})
 							}

diff --git a/internal/store/ingress_test.go b/internal/store/ingress_test.go
@@ -165,7 +165,7 @@ func TestIngressStore(t *testing.T) {
 				kube_ingress_info{namespace="ns4",ingress="ingress4",ingressclass="_default"} 1
 				kube_ingress_created{namespace="ns4",ingress="ingress4"} 1.501569018e+09
 				kube_ingress_path{namespace="ns4",ingress="ingress4",host="somehost",path="/somepath",service_name="someservice",service_port="1234"} 1
-				kube_ingress_path{namespace="ns4",ingress="ingress4",host="somehost",path="/somepath2",service_name="",service_port=""} 1
+				kube_ingress_path{namespace="ns4",ingress="ingress4",host="somehost",path="/somepath2",api_group="",kind="somekind",name="somename"} 1
 `,
 			MetricNames: []string{"kube_ingress_info", "kube_ingress_metadata_resource_version", "kube_ingress_created", "kube_ingress_labels", "kube_ingress_path", "kube_ingress_tls"},
 		},