Added a doc line to the missing helm value service.internal.loadBalancerIP

[fabioformosa]

#9403 Add documentation for controller.service.internal.loadBalancerIP in Helm chart

What this PR does / why we need it:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

#9403

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.
• Added Release Notes.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

• CLI change
• API change
• UI change
• configuration schema change
• behavioral change
• change in non-functional attributes such as efficiency or availability, availability of a new platform
• a warning about a deprecation
• fix of a previous Known Issue
• fix of a vulnerability (CVE)

No release notes are required for changes to the following:

• Tests
• Build infrastructure
• Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

 Add documentation for controller.service.internal.loadBalancerIP in Helm chart

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: fabioformosa / name: Fabio Formosa (55a420a, 61ce512, ad2afa8, 41c0546, 2389746, 701016b, 74015a4, b44d00d)

[k8s-ci-robot]

@fabioformosa: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @fabioformosa!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @fabioformosa. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

@fabioformosa thanks for this contribution.

It will be helpful to others if we merge this.
Please help out n the process as follows ;

• The README of hte chart is not edited manually. It has to be generated automatically using tooling. The tool to be used is called helm-docs
• Please refer to this https://github.com/kubernetes/ingress-nginx/blob/main/RELEASE.md#d-edit-the-valuesyaml-and-run-helm-docs . The values.yaml of the chart needs to be edited with your helpful text added fresh to values.yaml. Then use the helm-docs tool as documented in the link provided

Regards

[longwuyuan]

@fabioformosa sorry if i was not clear but this works if you push both the chnged values file as well as the autogenerated README.md from using the helm-docs tool. Is that what the new push is about ?

[strongjz]

There are cloud specific static deploys, if you want to use specific lb ip, i dont see why changing this helm for everyone is needed. Im inclined to close this PR without sufficient justification to change this for everyone.

• AWS https://github.com/kubernetes/ingress-nginx/blob/main/deploy/static/provider/cloud/deploy.yaml
• Generic Cloud https://github.com/kubernetes/ingress-nginx/blob/main/deploy/static/provider/cloud/deploy.yaml

/triage needs-information

[strongjz]

I just read through your issue attached to this. I would comment the loadBalancerIP value back out and leave in the updated description, then we can accept this PR.

Also you need to sign the CLA in order for us to accept this PR.

More info here https://github.com/kubernetes/community/blob/master/CLA.md

[fabioformosa]

/easycla

[strongjz]

@fabioformosa can you rebase so we can get this in for you.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx ready!

Name	Link
🔨 Latest commit	b44d00d
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/649aa8b6b9a0e800083130c2
😎 Deploy Preview	https://deploy-preview-9406--kubernetes-ingress-nginx.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[strongjz]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabioformosa, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [strongjz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment