Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dind in ci tests #8529

Merged
merged 1 commit into from
May 1, 2022
Merged

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented May 1, 2022

What this PR does / why we need it:

Something changed in CI tests and apparently presenting the DIND variable and wrapping bash first is not desired.

This is an attempt to fix it

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 1, 2022
@k8s-ci-robot
Copy link
Contributor

@rikatz: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2022
@rikatz rikatz merged commit 4cc0099 into kubernetes:main May 1, 2022
@rikatz
Copy link
Contributor Author

rikatz commented May 1, 2022

/test ci-ingress-nginx-e2e-main

@rikatz
Copy link
Contributor Author

rikatz commented May 1, 2022

/retest ci-ingress-nginx-e2e-main

@rikatz rikatz deleted the remove-dind-separate-test branch May 1, 2022 20:13
rikatz added a commit to rikatz/ingress-nginx that referenced this pull request May 2, 2022
k8s-ci-robot pushed a commit that referenced this pull request May 2, 2022
rikatz added a commit that referenced this pull request May 4, 2022
rikatz added a commit that referenced this pull request May 4, 2022
k8s-ci-robot pushed a commit that referenced this pull request May 4, 2022
k8s-ci-robot pushed a commit that referenced this pull request May 4, 2022
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants