release v1.2.0 #8491

longwuyuan · 2022-04-20T21:36:41Z

What this PR does / why we need it:

This is the PR to release controller v1.2.0
We have already promoted new images for the controller & controller-chroot

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation only

Which issue/s this PR fixes

No Issue was created as it is internal to the project and process is documented in RELEASE.md

How Has This Been Tested?

The CI pipeline will be the test. Manual verification of changes was done

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I've read the CONTRIBUTION guide
I have added tests to cover my changes.
All new and existing tests passed.

k8s-ci-robot · 2022-04-20T21:36:48Z

@longwuyuan: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

longwuyuan · 2022-04-20T21:44:54Z

/assign @rikatz

longwuyuan · 2022-04-20T22:16:05Z

/retest

Changelog.md

tao12345666333 · 2022-04-21T06:15:39Z

Changelog.md

+- [8479](https://github.com/kubernetes/ingress-nginx/pull/8479) changed nginx base img tag to img built with alpine3.14.6
+- [8478](https://github.com/kubernetes/ingress-nginx/pull/8478) update base images and protobuf gomod
+- [8468](https://github.com/kubernetes/ingress-nginx/pull/8468) Fallback to ngx.var.scheme for redirectScheme with use-forward-headers when X-Forwarded-Proto is empty
+


I think we should include what's in beta.0 and beta.1

added other non-housekeeping PRs as well. Please check

Please add the fact that this is a new minor due to breaking change, and saying about the chroot image and deep inspector as well (i did in beta.0 changelog)

I edited the Changelog description as per your advise. Please check @rikatz

The changelog is duplicated and seems missing some things, but I guess we can release and take care of it later

build/run-in-docker.sh

Changelog.md

tao12345666333

Only one last formatting issue remains, thanks a lot

Changelog.md

tao12345666333 · 2022-04-21T15:23:42Z

charts/ingress-nginx/CHANGELOG.md

+- "[8481](https://github.com/kubernetes/ingress-nginx/pull/8481) Fix log creation in chroot script"
+- "[8479](https://github.com/kubernetes/ingress-nginx/pull/8479) changed nginx base img tag to img built with alpine3.14.6"
+- "[8478](https://github.com/kubernetes/ingress-nginx/pull/8478) update base images and protobuf gomod"
+- "[8468](https://github.com/kubernetes/ingress-nginx/pull/8468) Fallback to ngx.var.scheme for redirectScheme with use-forward-headers when X-Forwarded-Proto is empty"
+- "[8456](https://github.com/kubernetes/ingress-nginx/pull/8456) Implement object deep inspector"
+- "[8455](https://github.com/kubernetes/ingress-nginx/pull/8455) Update dependencies"
+- "[8454](https://github.com/kubernetes/ingress-nginx/pull/8454) Update index.md"
+- "[8447](https://github.com/kubernetes/ingress-nginx/pull/8447) typo fixing"
+- "[8446](https://github.com/kubernetes/ingress-nginx/pull/8446) Fix suggested annotation-value-word-blocklist"
+- "[8444](https://github.com/kubernetes/ingress-nginx/pull/8444) replace deprecated topology key in example with current one"
+- "[8443](https://github.com/kubernetes/ingress-nginx/pull/8443) Add dependency review enforcement"
+- "[8434](https://github.com/kubernetes/ingress-nginx/pull/8434) added new auth-tls-match-cn annotation"
+- "[8426](https://github.com/kubernetes/ingress-nginx/pull/8426) Bump github.com/prometheus/common from 0.32.1 to 0.33.0"


They are not in the same format as before, can you unify them?

If you can, please fix the changelog of version 4.0.18 by the way, its format is also wrong

I tried to fix the missing lines as well as the missing hyphen. Please check

same as above As an example, the chroot is not here

tao12345666333

Thanks!

/lgtm
/approve
/hold

Hold for @rikatz comment

rikatz · 2022-04-22T02:35:46Z

/hold cancel
Changelog is not good, but we can release this and fix the files later.

I will make the release with the right Changelog and we can fix in a followup

rikatz · 2022-04-22T02:35:54Z

/approve
Tks!!

k8s-ci-robot · 2022-04-22T02:36:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longwuyuan, rikatz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rikatz,tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 20, 2022

k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 20, 2022

k8s-ci-robot requested review from cpanato and ElvinEfendi April 20, 2022 21:37

k8s-ci-robot added area/docs area/helm Issues or PRs related to helm charts labels Apr 20, 2022

k8s-ci-robot assigned rikatz Apr 20, 2022

tao12345666333 reviewed Apr 21, 2022

View reviewed changes

rikatz suggested changes Apr 21, 2022

View reviewed changes

build/run-in-docker.sh Outdated Show resolved Hide resolved

tao12345666333 reviewed Apr 21, 2022

View reviewed changes

Changelog.md Show resolved Hide resolved

Changelog.md Outdated Show resolved Hide resolved

tao12345666333 reviewed Apr 21, 2022

View reviewed changes

changes for release v1.2.0

133d12a

tao12345666333 approved these changes Apr 21, 2022

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2022

k8s-ci-robot assigned tao12345666333 Apr 21, 2022

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 21, 2022

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2022

k8s-ci-robot merged commit 6d9a39e into kubernetes:main Apr 22, 2022

longwuyuan deleted the release-v1.2.0 branch April 27, 2022 17:05

rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023

changes for release v1.2.0 (kubernetes#8491)

0800e6a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release v1.2.0 #8491

release v1.2.0 #8491

longwuyuan commented Apr 20, 2022 •

edited

Loading

k8s-ci-robot commented Apr 20, 2022

longwuyuan commented Apr 20, 2022

longwuyuan commented Apr 20, 2022

tao12345666333 Apr 21, 2022

longwuyuan Apr 21, 2022 •

edited

Loading

rikatz Apr 21, 2022

longwuyuan Apr 21, 2022 •

edited

Loading

rikatz Apr 22, 2022

tao12345666333 left a comment

tao12345666333 Apr 21, 2022

longwuyuan Apr 21, 2022

rikatz Apr 22, 2022

tao12345666333 left a comment

rikatz commented Apr 22, 2022

rikatz commented Apr 22, 2022

k8s-ci-robot commented Apr 22, 2022

release v1.2.0 #8491

release v1.2.0 #8491

Conversation

longwuyuan commented Apr 20, 2022 • edited Loading

What this PR does / why we need it:

Types of changes

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

k8s-ci-robot commented Apr 20, 2022

longwuyuan commented Apr 20, 2022

longwuyuan commented Apr 20, 2022

tao12345666333 Apr 21, 2022

Choose a reason for hiding this comment

longwuyuan Apr 21, 2022 • edited Loading

Choose a reason for hiding this comment

rikatz Apr 21, 2022

Choose a reason for hiding this comment

longwuyuan Apr 21, 2022 • edited Loading

Choose a reason for hiding this comment

rikatz Apr 22, 2022

Choose a reason for hiding this comment

tao12345666333 left a comment

Choose a reason for hiding this comment

tao12345666333 Apr 21, 2022

Choose a reason for hiding this comment

longwuyuan Apr 21, 2022

Choose a reason for hiding this comment

rikatz Apr 22, 2022

Choose a reason for hiding this comment

tao12345666333 left a comment

Choose a reason for hiding this comment

rikatz commented Apr 22, 2022

rikatz commented Apr 22, 2022

k8s-ci-robot commented Apr 22, 2022

longwuyuan commented Apr 20, 2022 •

edited

Loading

longwuyuan Apr 21, 2022 •

edited

Loading

longwuyuan Apr 21, 2022 •

edited

Loading