-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement object deep inspector #8456
Conversation
@rikatz: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Only a trivial comment. If you want to merge please unhold
/hold
wantErr: true, | ||
}, | ||
{ | ||
name: "invalid-path-etc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the name can be changed
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think we can merge it first. Minor tweaks can be put into follow-up PRs /hold cancel |
Signed-off-by: changzhen <[email protected]>
Implement object deep inspector (kubernetes#8456)
What this PR does / why we need it:
Implements deep inspection into objects, walking through all the spec (right now only for networking.Ingress) and checking for possible attempts to escape configs.
The annotation validation is still done in another part of the code and may be moved to the same inspector process in a future
Types of changes
How Has This Been Tested?
Added e2e tests and unit tests