replace deprecated topology key in example with current one

[froblesmartin]

Signed-off-by: Francisco Robles Martín [email protected]

What this PR does / why we need it:

Replace the value in an example to not suggest using a deprecated key. (https://kubernetes.io/docs/reference/labels-annotations-taints/#failure-domainbetakubernetesiozone)

Also the deprecation notice in k8s 1.17 changelog: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.17.md and the PR promoting the new labels: kubernetes/kubernetes#81431

Types of changes

• Documentation only

How Has This Been Tested?

No need for tests

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

@froblesmartin: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @froblesmartin!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @froblesmartin. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

Thanks for the contribution @froblesmartin. Seems good to go, but can you provide the link to the deprecation notice (sort of implied by the beta version already) just for explicit reference here. Or can you link to the list of keys... I searched but could not find the page ... maybe I have to lookup api reference ?
/ok-to-test

[froblesmartin]

Thanks for the contribution @froblesmartin. Seems good to go, but can you provide the link to the deprecation notice (sort of implied by the beta version already) just for explicit reference here. Or can you link to the list of keys... I searched but could not find the page ... maybe I have to lookup api reference ? /ok-to-test

Hi @longwuyuan! Thanks for your fast reply! 😄 Sure, I forgot about that 😅

In the k8s docs you can see it is deprecated: https://kubernetes.io/docs/reference/labels-annotations-taints/#failure-domainbetakubernetesiozone

Also the deprecation notice in k8s 1.17 changelog: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.17.md and the PR promoting the new labels: kubernetes/kubernetes#81431

[longwuyuan]

Thanks you for the links @froblesmartin . Helps .

/lgtm

[cpanato]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, froblesmartin, longwuyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [cpanato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment