Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve req handling dashboard #8322

Conversation

naseemkullah
Copy link
Contributor

@naseemkullah naseemkullah commented Mar 10, 2022

What this PR does / why we need it:

Display per method/path combos for various metrics, adjust titles, and sort tooltip by decreasing

Types of changes

  • New feature (non-breaking change which adds functionality)

Which issue/s this PR fixes

How Has This Been Tested?

Actively using this dashboard, worth noting original committer of it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 10, 2022
@k8s-ci-robot
Copy link
Contributor

@naseemkullah: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 10, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @naseemkullah. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 10, 2022
@k8s-ci-robot k8s-ci-robot requested review from rikatz and strongjz March 10, 2022 16:30
Display per method/path combos for various metrics, adjust titles, and sort tooltip by decreasing

Signed-off-by: Naseem Ullah <[email protected]>
@naseemkullah naseemkullah force-pushed the request-handling-dashboard-improvement branch from ab9193e to 249faa0 Compare March 10, 2022 16:32
@longwuyuan
Copy link
Contributor

  • Create an issue and put all the details of the problem you are trying to solve in that issue
  • Link that issue to this PR
  • Show screenshot of current problem here
  • Show screenshot of improvement using your fork's modified content also here

@naseemkullah
Copy link
Contributor Author

naseemkullah commented Mar 10, 2022

  • Create an issue and put all the details of the problem you are trying to solve in that issue
  • Link that issue to this PR
  • Show screenshot of current problem here
  • Show screenshot of improvement using your fork's modified content also here

Can we skip issue creation?

image
we get method cardinality for the various latency metrics, also polished the titles (casing, improved names)

image
tooltip: values are sorted form high to low

If this does not suffice please feel free to close

@longwuyuan
Copy link
Contributor

@naseemkullah , thanks you very much for your contribution. It helps .

  • The intention is not a "close" but the intention is to populate enough information here, so that revisits and maintenance does not become a challenge.
  • I see at at least 10-15 edits in the commit but there is no issue created to track what those edits are for and there is no information on those edits here except these 2 screenshots you have added. Would you be interested in adding more information as to what you found as problem(s) and what the several edits amount to.
  • At least the 2 screenshots are an improvement that is clearly visible so definitely suggesting we merge. Just wish for more info/documentation of the changes

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2022
@naseemkullah
Copy link
Contributor Author

Most changed lines are the updated Grafana version exporting with new schema, maybe I should run a 6.x Grafana to do the export of this if preferred I can look into this, alternatively if you use nginx ingress and Grafana yourself import this dashboard and have a look

@longwuyuan
Copy link
Contributor

longwuyuan commented Mar 11, 2022 via email

@rikatz
Copy link
Contributor

rikatz commented Apr 12, 2022

/lgtm
/approve
Thanks :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: naseemkullah, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit ea5a303 into kubernetes:main Apr 12, 2022
@naseemkullah naseemkullah deleted the request-handling-dashboard-improvement branch April 13, 2022 00:15
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
Display per method/path combos for various metrics, adjust titles, and sort tooltip by decreasing

Signed-off-by: Naseem Ullah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants