Validations #432
Merged
Validations #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gianrubio
commented
Mar 13, 2017
•
gianrubio
commented
- Validate if configmap exist and is in the namespace/name format
- Verifiy if watch-namespace option exist
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
aledbf
reviewed
Mar 13, 2017
| @@ -234,6 +244,13 @@ func createApiserverClient(apiserverHost string, kubeConfig string) (*client.Cli | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
| // test connection | |||
| _, err = client.ServerVersion() | |||
There was a problem hiding this comment.
Why are you doing this?
If is not possible to reach the api server this error is returned.
In any other case the client will retry the connection.
There was a problem hiding this comment.
I didn't realise this, rolled back.
Verifiy if watch-namespace option exist
gianrubio
force-pushed
the
validate-configmap
branch
from
3524361 to
c6195c4
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@gianrubio thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.