-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Ensure monitoring for custom error pages #3143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/lgtm |
@Globegitter thanks! |
Ah, I used the |
Codecov Report
@@ Coverage Diff @@
## master #3143 +/- ##
=======================================
Coverage 47.68% 47.68%
=======================================
Files 77 77
Lines 5708 5708
=======================================
Hits 2722 2722
Misses 2630 2630
Partials 356 356 Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, Globegitter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@aledbf thanks for the quick response, do you think it would be possible to have a patch release for this fix? Or even if there is just a nightly/dev build that would also work to have the fix already in place until the next release. |
@Globegitter sure, use |
What this PR does / why we need it: This should fix missing metrics when custom error pages are activated
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #3140Special notes for your reviewer: I am not super familiar with the lua setup but hope that should do it.