Hotfix: influxdb module enable disable toggle #2654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lorenzo Fontana <[email protected]>
k8s-ci-robot
added
the
size/XS
fntlnz
changed the title
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @aledbf |
Codecov Report
@@ Coverage Diff @@
## master #2654 +/- ##
=======================================
Coverage 40.77% 40.77%
=======================================
Files 74 74
Lines 5077 5077
=======================================
Hits 2070 2070
Misses 2724 2724
Partials 283 283Continue to review full report at Codecov.
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, fntlnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lorenzo Fontana [email protected]
What this PR does / why we need it:
After a major change in how the module collects metrics there has been a programming error that led to a bad enabled/disabled state for the influxdb module.
The issue had been fixed here influxdata/nginx-influxdb-module#9 and this pr is to update the ingress to reflect that fix.