include lua-resty-balancer in nginx image #2385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
|
/approve |
|
/lgtm |
k8s-ci-robot
added
approved
k8s-ci-robot
removed
the
lgtm
|
@ElvinEfendi you need to rebase (.travis is not up to date) |
|
hmm it should be up-to-date though, I'd rebased after your PR merged. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The PR includes https://github.com/openresty/lua-resty-balancer in the base Nginx image. The library has both Round Robin and consistent hashing load balancing implementations. In subsequent PRs I'll make use of consistent hashing to support https://github.com/kubernetes/ingress-nginx/blob/master/docs/user-guide/annotations.md#custom-nginx-upstream-hashing when dynamic configuration is enabled and then refactor balancer.lua to use Round Robin implementation from this library instead of reimplementing it ourselves.
Which issue this PR fixes: n/a
Special notes for your reviewer: n/a