Skip to content

Review $request_id #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2018
Merged

Review $request_id #2363

merged 1 commit into from
Apr 17, 2018

Conversation

gianrubio
Copy link
Contributor

This map detect if request_id header where injected before assign a new value for request_id.

More info here

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2018
@aledbf aledbf self-assigned this Apr 17, 2018
@aledbf
Copy link
Member

aledbf commented Apr 17, 2018

@gianrubio please squash the commits

@aledbf
Copy link
Member

aledbf commented Apr 17, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2018
@gianrubio
Copy link
Contributor Author

commits squashed

ElvinEfendi
ElvinEfendi reviewed Apr 17, 2018
View reviewed changes
docs/examples/customization/configuration-snippets/ingress.yaml Outdated
@@ -4,7 +4,7 @@ metadata:
name: nginx-configuration-snippet
annotations:
nginx.ingress.kubernetes.io/configuration-snippet: |
more_set_headers "Request-Id: $request_id";
more_set_headers "Request-Id: $req";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not be $req_id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I'm gonna fix

@codecov-io
Copy link

Codecov Report

Merging #2363 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2363   +/-   ##
=======================================
  Coverage   39.11%   39.11%           
=======================================
  Files          73       73           
  Lines        5203     5203           
=======================================
  Hits         2035     2035           
  Misses       2878     2878           
  Partials      290      290
Impacted Files Coverage Δ
internal/file/bindata.go 57.42% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc943a...c60ed24. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Apr 17, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, gianrubio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 085263f into kubernetes:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElvinEfendi ElvinEfendi ElvinEfendi left review comments

Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gianrubio @aledbf @codecov-io @k8s-ci-robot @ElvinEfendi