Skip to content

add http/2 #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2018
Merged

add http/2 #2242

merged 1 commit into from
Mar 22, 2018

Conversation

agau4779
Copy link
Contributor

What this PR does / why we need it:
Enables HTTP2 on port 8443 for echoheaders.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
Required to test HTTP/2 in Kubernetes Ingress

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 22, 2018
@agau4779
Copy link
Contributor Author

/assign nicksardo aledbf

@nicksardo
Copy link
Contributor

Thanks @agau4779.

You see any problems with having this, @aledbf? FYI, @agau4779 is on our team and working on ingress-gce.

@nicksardo
Copy link
Contributor

/lgtm
Leaving approval to @aledbf

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 22, 2018
@aledbf
Copy link
Member

aledbf commented Mar 22, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agau4779, aledbf, nicksardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member

aledbf commented Mar 22, 2018

@nicksardo please merge and publish the image

@aledbf
Copy link
Member

aledbf commented Mar 22, 2018

You see any problems with having this, @aledbf? FYI, @agau4779 is on our team and working on ingress-gce.

No.

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit 935a5ef into kubernetes:master Mar 22, 2018
@nicksardo
Copy link
Contributor

/lgtm

@nicksardo
Copy link
Contributor

Thanks! Published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants