Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuring load balancing per ingress #2167

Merged
merged 2 commits into from
Mar 9, 2018
Merged

configuring load balancing per ingress #2167

merged 2 commits into from
Mar 9, 2018

Conversation

ElvinEfendi
Copy link
Member

@ElvinEfendi ElvinEfendi commented Mar 5, 2018

What this PR does / why we need it:
Adds a support for new annotation so that users can configure a load balancing algorithm per ingress.

Which issue this PR fixes *: fixes #1834

Special notes for your reviewer: n/a

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 5, 2018
@codecov-io
Copy link

codecov-io commented Mar 9, 2018

Codecov Report

Merging #2167 into master will increase coverage by 0.18%.
The diff coverage is 39.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2167      +/-   ##
==========================================
+ Coverage    36.4%   36.58%   +0.18%     
==========================================
  Files          69       70       +1     
  Lines        4859     4884      +25     
==========================================
+ Hits         1769     1787      +18     
- Misses       2820     2822       +2     
- Partials      270      275       +5
Impacted Files Coverage Δ
internal/ingress/controller/controller.go 0% <0%> (ø) ⬆️
internal/ingress/types_equals.go 12.67% <0%> (-0.09%) ⬇️
internal/ingress/annotations/loadbalancing/main.go 100% <100%> (ø)
internal/ingress/annotations/annotations.go 80% <100%> (+0.33%) ⬆️
internal/file/bindata.go 43.07% <100%> (ø) ⬆️
internal/ingress/controller/template/template.go 63.28% <21.42%> (+0.53%) ⬆️
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️
cmd/nginx/main.go 23.44% <0%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a49d67...a3e9f55. Read the comment docs.

@ElvinEfendi ElvinEfendi changed the title initial code for per ingress load balancing configuration configuring load balancing per ingress Mar 9, 2018
@ElvinEfendi
Copy link
Member Author

/assign @dcbw

@ElvinEfendi
Copy link
Member Author

/cc @brava-vinh

@k8s-ci-robot
Copy link
Contributor

@ElvinEfendi: GitHub didn't allow me to request PR reviews from the following users: brava-vinh.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @brava-vinh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aledbf
Copy link
Member

aledbf commented Mar 9, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2018
@aledbf aledbf merged commit 36cce00 into kubernetes:master Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support load-balancer per ingress [FEATURE REQUEST]
5 participants