Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gzip_vary #1620

Merged
merged 1 commit into from
Oct 29, 2017
Merged

Add gzip_vary #1620

merged 1 commit into from
Oct 29, 2017

Conversation

acoshift
Copy link
Contributor

What this PR does / why we need it: Add gzip_vary on;

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): If gzip_vary don't turn on, CDN will cached gzipped response and return gzipped version to request which don't have Accept-Encoding: gzip header

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 29, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 33.098% when pulling 589b358 on acoshift:fix-gzip-vary into 2a9e1eb on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Oct 29, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2017
@aledbf
Copy link
Member

aledbf commented Oct 29, 2017

@acoshift thanks!

@aledbf aledbf merged commit bc77fae into kubernetes:master Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants