Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor helm ci tests part I #11188

Merged
merged 5 commits into from
Apr 1, 2024
Merged

refactor helm ci tests part I #11188

merged 5 commits into from
Apr 1, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link
Contributor

This is an automated cherry-pick of #11178

/assign Gacko

cpanato added 5 commits April 1, 2024 11:12
@cpanato
refactor helm ci tests part I
0e6563c 
Signed-off-by: cpanato <[email protected]>
@cpanato
update indentation
45a0ac1 
Signed-off-by: cpanato <[email protected]>
@cpanato
fix path
2d838b9 
Signed-off-by: cpanato <[email protected]>
@cpanato
more updates
94e92c6 
Signed-off-by: cpanato <[email protected]>
@cpanato
add helm-lint job
e1d2c47 
Signed-off-by: cpanato <[email protected]>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 1, 2024
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/helm Issues or PRs related to helm charts needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2024
@Gacko
Copy link
Member

Gacko commented Apr 1, 2024

/triage accepted
/retitle refactor helm ci tests part I
/kind cleanup
/priority backlog
/approved

@k8s-ci-robot k8s-ci-robot changed the title [release-1.10] refactor helm ci tests part I refactor helm ci tests part I Apr 1, 2024
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Apr 1, 2024
@Gacko
Copy link
Member

Gacko commented Apr 1, 2024

/approve

@Gacko
Copy link
Member

Gacko commented Apr 1, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2024
@Gacko
Copy link
Member

Gacko commented Apr 1, 2024

/cc @cpanato @rikatz

@k8s-ci-robot k8s-ci-robot requested review from cpanato and rikatz April 1, 2024 11:36
cpanato
cpanato approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Gacko, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9792162 into kubernetes:release-1.10 Apr 1, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@strongjz strongjz Awaiting requested review from strongjz

@ubergesundheit ubergesundheit Awaiting requested review from ubergesundheit

@rikatz rikatz Awaiting requested review from rikatz

Assignees

@Gacko Gacko

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k8s-infra-cherrypick-robot @Gacko @k8s-ci-robot @cpanato