Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pinned golang to 1.20.5 #10127

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

longwuyuan
Copy link
Contributor

What this PR does / why we need it:

  • Go was bumped to v1.20.5
  • This PR bumps go to 1.20.5 in pinned locations
  • This will trigger build of new images including webhook certgen
  • 2 Follow up PRs will be needed. One to promote new images and another to change tag+sha in project to use new images

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

  • No issues was created

How Has This Been Tested?

  • Will be tested only after new images are built, promoted and e2e-tests use new images

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

/triage accepted
/priority important-soon

@tao12345666333 @strongjz @rikatz @cpanato Please review lgtm approve before releasing controller v1.8.1 as values.yaml will need new webhook certgen image

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2023
@k8s-ci-robot k8s-ci-robot requested review from cpanato and rikatz June 24, 2023 01:47
Copy link
Member

@strongjz strongjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also make these alpine 3.18.3 explicitly

@longwuyuan
Copy link
Contributor Author

Can you also make these alpine 3.18.3 explicitly

ok, doing that now

@longwuyuan
Copy link
Contributor Author

longwuyuan commented Jun 24, 2023

@strongjz need advise as unable to find explicit 3.18.3

image

@strongjz
Copy link
Member

Sorry, I mean 3.18.2

@longwuyuan
Copy link
Contributor Author

Sorry, I mean 3.18.2

ok, doing that now

@longwuyuan
Copy link
Contributor Author

Oh, @strongjz seems that revision 2 in tag is not available

% date ; docker pull golang:1.20.5-alpine3.18.2
Sat Jun 24 07:43:18 AM IST 2023
Error response from daemon: manifest for golang:1.20.5-alpine3.18.2 not found: manifest unknown: manifest unknown

image

@longwuyuan longwuyuan requested a review from strongjz June 24, 2023 02:33
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker run --rm -it golang:1.20.5-alpine3.18 sh
/go # cat /etc/os-release 
NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.18.2
PRETTY_NAME="Alpine Linux v3.18"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://gitlab.alpinelinux.org/alpine/aports/-/issues"

This image has been bump to alpine 3.18.2, let's merge this one.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longwuyuan, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 643c475 into kubernetes:main Jun 26, 2023
@longwuyuan
Copy link
Contributor Author

ok... will submit k8s.io PR after the new images are built

@longwuyuan longwuyuan deleted the bumpgolang1205 branch June 26, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants