-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump pinned golang to 1.20.5 #10127
bump pinned golang to 1.20.5 #10127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also make these alpine 3.18.3 explicitly
ok, doing that now |
@strongjz need advise as unable to find explicit 3.18.3 |
Sorry, I mean 3.18.2 |
ok, doing that now |
Oh, @strongjz seems that revision 2 in tag is not available % date ; docker pull golang:1.20.5-alpine3.18.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker run --rm -it golang:1.20.5-alpine3.18 sh
/go # cat /etc/os-release
NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.18.2
PRETTY_NAME="Alpine Linux v3.18"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://gitlab.alpinelinux.org/alpine/aports/-/issues"
This image has been bump to alpine 3.18.2, let's merge this one.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longwuyuan, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ok... will submit k8s.io PR after the new images are built |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist:
/triage accepted
/priority important-soon
@tao12345666333 @strongjz @rikatz @cpanato Please review lgtm approve before releasing controller v1.8.1 as values.yaml will need new webhook certgen image