Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed tagsha to recent builds #10001

Merged
merged 1 commit into from
May 27, 2023
Merged

changed tagsha to recent builds #10001

merged 1 commit into from
May 27, 2023

Conversation

longwuyuan
Copy link
Contributor

What this PR does / why we need it:

  • Several images used in CI got rebuilt with changes like move to alpine v3.18
  • This PR changes tag+sha of multiple images to recent builds

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

  • No dedicated issue created as internal and part of multi PR process

How Has This Been Tested?

  • Will be tested in CI

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

cc @tao12345666333 @strongjz @rikatz

/triage accepted
/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/docs area/helm Issues or PRs related to helm charts labels May 27, 2023
@k8s-ci-robot k8s-ci-robot requested review from rikatz and strongjz May 27, 2023 11:39
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 27, 2023
tao12345666333
tao12345666333 reviewed May 27, 2023
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 27, 2023
@tao12345666333
Copy link
Member

after kubernetes/k8s.io#5333 (comment) has been merged. we can change and update the image sha in this PR?

@longwuyuan
Copy link
Contributor Author

longwuyuan commented May 27, 2023 via email

@longwuyuan longwuyuan force-pushed the change-to-alpine318 branch from d40ce94 to c7c7aad Compare May 27, 2023 13:35
@longwuyuan
Copy link
Contributor Author

@tao12345666333 echoserver also changed so now waiting for CI

@longwuyuan
Copy link
Contributor Author

@tao12345666333 @strongjz CI passed

@strongjz
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longwuyuan, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit f7ea0b1 into kubernetes:main May 27, 2023
@longwuyuan longwuyuan deleted the change-to-alpine318 branch May 27, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 left review comments

@rikatz rikatz Awaiting requested review from rikatz

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@strongjz strongjz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@longwuyuan @tao12345666333 @strongjz @k8s-ci-robot