-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verify-examples.sh and switch from makefiles to go test and go generate #249
Conversation
Awesome, can't wait to see the CI! |
/hold still making this better |
provides additional header path argument to make gen so that it is portable without having k8s.io/gengo in your GOPATH. also ensures defaulter-gen is run from within _output_tests to fix bug where packages were no longer being processed unless a go.work file is present
and not require go install
e97f98c
to
ee399ae
Compare
make gen
more portable
I don't know how I feel about having both the makefile and the shell script? |
agreed. removed the makefiles since they are supplanted by the verify script. However import-boss still retains a makefile since its test is quite different. I could refactor it to run as part of |
cc3fa36
to
bce53be
Compare
/hold cancel |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, apelisse, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR:
generate.go
to deepcopy-gen and defaulter-gen, and fixes theset-gen
generate to not rely on GOPATH. This enables the more standardgo generate
to be used over ad-hoc makefileshack/verify-examples.sh
which will be called from CI to:GOPATH
to rungo generate
andgo test
workflowsAfter this PR we will be able to regenerate and rerun all examples tests in CI by invoking
hack/verify-examples.sh
/cc @apelisse