Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: convert to a very basic Helm chart #108

Closed
wants to merge 3 commits into from

Conversation

kingdonb
Copy link

@kingdonb kingdonb commented Oct 8, 2017

with only one parameter (the clusterIP of the NFS service)

with only one parameter (the clusterIP of the NFS service)
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2017
@kingdonb kingdonb changed the title convert to a very basic Helm chart WIP: convert to a very basic Helm chart Oct 8, 2017
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2017
@kingdonb kingdonb mentioned this pull request Oct 8, 2017
@ahmetb
Copy link
Member

ahmetb commented Oct 8, 2017

This is great work, but would you consider submitting it directly to https://github.com/kubernetes/charts/tree/master/incubator which is a better home for this?

@kingdonb
Copy link
Author

Closing in favor of placing this change at helm/charts#2559

@kingdonb kingdonb closed this Oct 22, 2017
@ahmetb
Copy link
Member

ahmetb commented Oct 23, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants