Add jpbetz to prod-readiness-approvers #4343
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/assign @johnbelamaric @deads2k @wojtek-t |
|
@jpbetz in the prr meeting on Wednesday, there was discussion about linking to review comments in PRs to add ourselves to approvers so it would simply the review. Could you update the issue description with links to the review comments for the issues you linked? |
I've added links to the PRs reviewed and to the review comments. |
k8s-ci-robot
added
the
approved
|
Now being pedantic here:
I don't think the minor stuff about should be blocking, but I'm wondering about the second bullet point above [though if we consciously make a "non-blocking" decision, I would be fine with that too, but primarily because I know Joe and I've seen him pushing back in other situations]. |
I thought this showed a bit of that: |
I think it's good example of questioning status-quo, but not necessary pushing for sth. [As I said, I'm not saying we should necessarily block on that, just trying to figure out where we're putting the bar, so having @deads2k opinion here would be helpful] |
|
Friendly ping on this. |
|
The diversity of review requirements is well met. Regarding the ability to go back and forth with authors to explain and (as gently as possible) require the project standards to be met. While it's ideal to see that in an PRR review that required it (and a significant negative if it was necessary and lacking), I'm comfortable using our five year history and knowledge of this candidate to fulfill the requirement. I can't guarantee that existing approvers will have that knowledge of all future candidates and if we don't have it we won't be able to use it for future candidates. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, johnbelamaric, jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Shadow contribution summary:
Planned future involvement:
Shadow reviewer promotion criteria:
Transitions from new to alpha
Transitions from alpha to beta
Transitions from beta to GA
Three enhancements that require coordination between multiple components.
Three enhancements that require version skew consideration (both HA and component skew): does behavior fail safely and eventually reconcile.
Three enhancements that are outside your primary domain.
Examples where the feature requires considering the case of administering thousands of clusters. This comes up frequently for host-based features in storage, node, or networking.
Examples where the feature requires considering the case of very large clusters. This is commonly covered by metrics.