Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3333: mark status as implemented #4111

Merged
merged 1 commit into from
Sep 6, 2023
Merged

KEP-3333: mark status as implemented #4111

merged 1 commit into from
Sep 6, 2023

Conversation

carlory
Copy link
Member

@carlory carlory commented Jun 28, 2023 •
edited
Loading

  • One-line PR description: mark status as implemented
  • Other comments: all the tasks are done.

@k8s-ci-robot k8s-ci-robot requested a review from msau42 June 28, 2023 07:15
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jun 28, 2023
@k8s-ci-robot k8s-ci-robot requested a review from xing-yang June 28, 2023 07:15
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 28, 2023
@carlory
Copy link
Member Author

carlory commented Jun 28, 2023

/hold util kubernetes/website#41206 is merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2023
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2023
@carlory
Copy link
Member Author

carlory commented Jul 3, 2023

/retest

@carlory
Copy link
Member Author

carlory commented Sep 4, 2023

/hold cancel

/assign @saad-ali @jsafrane

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2023
@carlory
Copy link
Member Author

carlory commented Sep 6, 2023

/cc @xing-yang

@jsafrane
Copy link
Member

jsafrane commented Sep 6, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit a13fcf1 into kubernetes:master Sep 6, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 Awaiting requested review from msau42

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@jsafrane jsafrane

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
5 participants
@carlory @k8s-triage-robot @jsafrane @k8s-ci-robot @saad-ali