Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2413: Graduate SeccompDefault feature to beta #3240

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Mar 15, 2022

Updating the SeccompDefault feature to beta, targeting for the v1.25 cycle.

Refers to #2413

cc @kubernetes/sig-node-proposals @mrunalp

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 15, 2022
@saschagrunert saschagrunert force-pushed the seccomp-default-beta branch 3 times, most recently from 121e358 to 051095f Compare March 15, 2022 10:04
@kikisdeliveryservice kikisdeliveryservice changed the title Graduate SeccompDefault feature to beta KEP-2413: Graduate SeccompDefault feature to beta Apr 5, 2022
@saschagrunert saschagrunert force-pushed the seccomp-default-beta branch from 051095f to b49d9dd Compare May 11, 2022 07:31
@saschagrunert
Copy link
Member Author

@kubernetes/sig-architecture PTAL as well :)

@dims
Copy link
Member

dims commented May 24, 2022

@saschagrunert ACK. will do later this week unless John or Derek are able to before me

@saschagrunert saschagrunert force-pushed the seccomp-default-beta branch 2 times, most recently from d3f0acf to 37973cf Compare May 30, 2022 08:07
@dims
Copy link
Member

dims commented Jun 1, 2022

/assign @mrunalp @derekwaynecarr

@mrunalp
Copy link
Contributor

mrunalp commented Jun 3, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2022
@k8s-ci-robot k8s-ci-robot added the kind/design Categorizes issue or PR as related to design. label Jun 9, 2022
@dchen1107 dchen1107 added this to the v1.25 milestone Jun 9, 2022
@saschagrunert saschagrunert force-pushed the seccomp-default-beta branch from 37973cf to 752e371 Compare June 14, 2022 08:19
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2022
@saschagrunert saschagrunert force-pushed the seccomp-default-beta branch from 752e371 to 2818f12 Compare June 14, 2022 08:23
@saschagrunert saschagrunert force-pushed the seccomp-default-beta branch 4 times, most recently from a49cc19 to 8cd5b39 Compare June 15, 2022 08:03
@saschagrunert saschagrunert force-pushed the seccomp-default-beta branch from 8cd5b39 to 9a124fd Compare June 15, 2022 08:14
@saschagrunert
Copy link
Member Author

@liggitt I dropped the API awareness, so I guess there is no API review required any more

@mrunalp I added the new test plan section, which basically covers a new serial e2e test if the feature gate is enabled by default

@deads2k incorporated the PRR review, PTAL

Thank you all! 🙏

@mrunalp
Copy link
Contributor

mrunalp commented Jun 15, 2022

@mrunalp I added the new test plan section, which basically covers a new serial e2e test if the feature gate is enabled by default
Looks good 👍

@derekwaynecarr
Copy link
Member

thanks for the updates.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2022
@saschagrunert
Copy link
Member Author

/assign @johnbelamaric

@deads2k
Copy link
Contributor

deads2k commented Jun 17, 2022

thanks for the update, PRR looks good.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, derekwaynecarr, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit b324c1f into kubernetes:master Jun 17, 2022
@saschagrunert saschagrunert deleted the seccomp-default-beta branch June 20, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/design Categorizes issue or PR as related to design. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

10 participants