Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating from old kep to new template -sig cli keps #2378

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Migrating from old kep to new template -sig cli keps #2378

merged 1 commit into from
Feb 1, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 30, 2021

Related to: #2220

Migrating the old KEP files into new format - sig-cli

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @shekhar-rajak. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 30, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Jan 30, 2021
This was referenced Jan 30, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghost ghost force-pushed the kep_new_template_sig_cli branch from a4dbb26 to 80ecdf7 Compare January 30, 2021 18:09
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2021
@ghost ghost force-pushed the kep_new_template_sig_cli branch from 80ecdf7 to 0a02d6d Compare January 30, 2021 18:12
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2021
@ghost
Copy link
Author

ghost commented Jan 30, 2021

This PR is ready for review.

@wojtek-t
Copy link
Member

wojtek-t commented Feb 1, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 1, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 1, 2021
@Shekharrajak
Migrating from old kep to new template: sig cli keps
3e4e417 
Minor change: corrected the file path

minor change - fix yaml parse error
@ghost ghost force-pushed the kep_new_template_sig_cli branch from 0a02d6d to 3e4e417 Compare February 1, 2021 17:04
@ghost
Copy link
Author

ghost commented Feb 1, 2021

The test failure error is fixed in new commit. It was related to extra " in one of the key.yaml file.

soltysh
soltysh approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@soltysh
Copy link
Contributor

soltysh commented Feb 1, 2021

Thanks @shekhar-rajak for your work!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shekhar-rajak, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4bedad8 into kubernetes:master Feb 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 1, 2021
@ghost
Copy link
Author

ghost commented Feb 1, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwittrock pwittrock Awaiting requested review from pwittrock

@seans3 seans3 Awaiting requested review from seans3

Assignees

@soltysh soltysh

@eddiezane eddiezane

@seans3 seans3

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
7 participants
@k8s-ci-robot @wojtek-t @soltysh @eddiezane @seans3 @pwittrock @Shekharrajak