query_test.go added - TestValidate method defined #2298

ghost · 2021-01-20T18:54:57Z

Related to #2297



$ go test -v query_test.go create.go  kepctl.go  promote.go query.go  

=== RUN   TestValidate
=== RUN   TestValidate/Valid_SIG
=== RUN   TestValidate/Invalid_SIG
=== RUN   TestValidate/Unsupported_Output_format
--- PASS: TestValidate (0.00s)
    --- PASS: TestValidate/Valid_SIG (0.00s)
    --- PASS: TestValidate/Invalid_SIG (0.00s)
    --- PASS: TestValidate/Unsupported_Output_format (0.00s)
PASS
ok  	command-line-arguments	2.798s

k8s-ci-robot · 2021-01-20T18:55:05Z

Hi @shekhar-rajak. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ghost · 2021-01-20T19:00:04Z

Please let me know, if I need to squash the commits.

kikisdeliveryservice · 2021-01-20T22:56:24Z

/ok-to-test

kikisdeliveryservice · 2021-01-20T22:59:07Z

Please let me know, if I need to squash the commits.

I would squash the commits :)

Pinging @jeremyrickard @palnabarun since they're working on this - also I don't see a kepval/kepctl label for these types of prs? should we add.

johnbelamaric · 2021-01-21T00:52:58Z

pkg/kepctl/query_test.go

@@ -0,0 +1,89 @@
+/*
+Copyright 2020 The Kubernetes Authors.


Copyright headers of all files need not be changed. IIRC, whenever we create a new file, we use the year of creation.

@palnabarun is correct, just when a new file is created.

ghost · 2021-01-21T13:53:42Z

I have squashed the commits. Please review.

ghost · 2021-01-21T13:54:22Z

Once this is merged I can add more testcases as part of #2282

palnabarun · 2021-01-25T11:59:02Z

/sig release
/sig architecture
/area enhancements

palnabarun · 2021-01-25T11:59:09Z

/cc

kikisdeliveryservice

Also q for line 69 comment: "// check if the Output specified is one of "", "json" or "yaml""

It seems stale? Shouldnt that be table json yaml? If so could you update since we're in the file anyway? :)

kikisdeliveryservice · 2021-01-25T22:18:27Z

pkg/kepctl/query.go

@@ -54,7 +54,7 @@ type QueryOpts struct {
 }

 // Validate checks the args and cleans them up if needed


Q (since you're in this file already 😄 ): is this comment^^ correct?

I don't really see the func cleaning them up?

Yeah, we can see function is not using the args now. Removing this comment. Thanks for the review.

ghost · 2021-01-27T14:53:50Z

I think, now it is good to test and review. Once this PR is merged, I will work on #2282 test cases

justaugustus

@shekhar-rajak -- Just two nits here.

justaugustus · 2021-01-27T17:22:51Z

pkg/kepctl/query_test.go

+/*
+
+TO run the test case: go test -v query_test.go create.go  kepctl.go  promote.go query.go
+
+*/


Suggested change

/*

TO run the test case: go test -v query_test.go create.go kepctl.go promote.go query.go

*/

You can drop this note.

justaugustus · 2021-01-27T17:23:27Z

pkg/kepctl/query_test.go

+	"fmt"
+	"testing"
+
+	"github.com/stretchr/testify/assert"


Tool choice nit: prefer require instead of assert
Example usage: https://github.com/kubernetes/release/blob/dd16298a1a178a937e02c69a69d6e2c15484fc4e/pkg/anago/anago_test.go#L23

ghost · 2021-01-27T18:05:07Z

Thanks @justaugustus, for the review. I have updated the commit. I think now it is good to go.

justaugustus · 2021-01-27T18:51:06Z

Thanks!
/lgtm
/approve

k8s-ci-robot · 2021-01-27T18:51:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, shekhar-rajak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2021

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 20, 2021

k8s-ci-robot requested review from jeremyrickard and lasomethingsomething January 20, 2021 18:55

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2021

johnbelamaric reviewed Jan 21, 2021

View reviewed changes

ghost force-pushed the query_test branch from 3dea612 to 53e87ff Compare January 21, 2021 13:44

k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/enhancements Issues or PRs related to the Enhancements subproject labels Jan 25, 2021

k8s-ci-robot requested a review from palnabarun January 25, 2021 11:59

kikisdeliveryservice reviewed Jan 25, 2021

View reviewed changes

ghost force-pushed the query_test branch from 53e87ff to 6cbbc42 Compare January 26, 2021 09:59

justaugustus requested changes Jan 27, 2021

View reviewed changes

query_test.go added - TestValidate method defined

1e22f0b

Validate funtion: removed unused arguments minor change: Copyright 2020 to Copyright 2021 Unnecessary comment is removed Using require instead of assert in test file

ghost force-pushed the query_test branch from 6cbbc42 to 1e22f0b Compare January 27, 2021 18:04

k8s-ci-robot assigned justaugustus Jan 27, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2021

k8s-ci-robot merged commit 8cac891 into kubernetes:master Jan 27, 2021

k8s-ci-robot added this to the v1.21 milestone Jan 27, 2021

lingsamuel mentioned this pull request Jan 28, 2021

Fix query cmd opts.Validate and test func name #2357

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

query_test.go added - TestValidate method defined #2298

query_test.go added - TestValidate method defined #2298

ghost commented Jan 20, 2021 •

edited by ghost

Loading

k8s-ci-robot commented Jan 20, 2021

ghost commented Jan 20, 2021

kikisdeliveryservice commented Jan 20, 2021

kikisdeliveryservice commented Jan 20, 2021 •

edited

Loading

johnbelamaric Jan 21, 2021

ghost Jan 21, 2021

palnabarun Jan 25, 2021

mrbobbytables Jan 25, 2021

ghost commented Jan 21, 2021

ghost commented Jan 21, 2021

palnabarun commented Jan 25, 2021

palnabarun commented Jan 25, 2021

kikisdeliveryservice left a comment

kikisdeliveryservice Jan 25, 2021

ghost Jan 26, 2021

ghost commented Jan 27, 2021

justaugustus left a comment

justaugustus Jan 27, 2021

ghost Jan 27, 2021

justaugustus Jan 27, 2021

ghost Jan 27, 2021

ghost commented Jan 27, 2021

justaugustus commented Jan 27, 2021

k8s-ci-robot commented Jan 27, 2021

		@@ -54,7 +54,7 @@ type QueryOpts struct {
		}

		// Validate checks the args and cleans them up if needed

query_test.go added - TestValidate method defined #2298

query_test.go added - TestValidate method defined #2298

Conversation

ghost commented Jan 20, 2021 • edited by ghost Loading

k8s-ci-robot commented Jan 20, 2021

ghost commented Jan 20, 2021

kikisdeliveryservice commented Jan 20, 2021

kikisdeliveryservice commented Jan 20, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Jan 21, 2021

ghost commented Jan 21, 2021

palnabarun commented Jan 25, 2021

palnabarun commented Jan 25, 2021

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Jan 27, 2021

justaugustus left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Jan 27, 2021

justaugustus commented Jan 27, 2021

k8s-ci-robot commented Jan 27, 2021

ghost commented Jan 20, 2021 •

edited by ghost

Loading

kikisdeliveryservice commented Jan 20, 2021 •

edited

Loading