Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scripts and go modules #1181

Merged
merged 1 commit into from
Jul 29, 2019
Merged

fix scripts and go modules #1181

merged 1 commit into from
Jul 29, 2019

Conversation

BenTheElder
Copy link
Member

  • fix all scripts to get the repo root correctly
  • create a tempdir in all scripts and use this to perform go get in module mode and store output binaries
  • fix some minor quoting issues

avoids creating go.mod / go.sum in the repo when running these scripts locally, fixes non-functional hack/update-toc.sh which was using (non-existent) vendor instead of go modules

@BenTheElder
Copy link
Member Author

/assign @justaugustus

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/pm labels Jul 29, 2019
@BenTheElder
Copy link
Member Author

cc @CHA per @justaugustus

@BenTheElder
Copy link
Member Author

er wrong cha, sorry! @chuckha 🙃

@BenTheElder BenTheElder mentioned this pull request Jul 29, 2019
Merged
@justaugustus
Copy link
Member

Thanks for fixing this up, @BenTheElder!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 829d70e into kubernetes:master Jul 29, 2019
@chuckha
Copy link
Contributor

chuckha commented Jul 29, 2019

ah, thanks @BenTheElder !

This was referenced Jul 29, 2019
Closed
Merged
@BenTheElder BenTheElder deleted the no-dirtying-the-repo branch July 29, 2019 21:41
@justaugustus justaugustus added area/enhancements Issues or PRs related to the Enhancements subproject and removed sig/pm labels Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/enhancements Issues or PRs related to the Enhancements subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @justaugustus @k8s-ci-robot @chuckha