Skip to content

Commit

Permalink
Move non-graceful node shutdown to GA
Browse files Browse the repository at this point in the history
  • Loading branch information
xing-yang committed May 24, 2023
1 parent a1db1a1 commit 6367497
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
2 changes: 2 additions & 0 deletions keps/prod-readiness/sig-storage/2268.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@ kep-number: 2268
alpha:
approver: "@deads2k"
beta:
approver: "@deads2k"
stable:
approver: "@deads2k"
6 changes: 3 additions & 3 deletions keps/sig-storage/2268-non-graceful-shutdown/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -393,11 +393,11 @@ Pick one more of these and delete the rest.
-->
- [X] Metrics
- Metric name:
- We can add new metrics `deleting_pods_total`, `deleting_pods_error_total`
- We added new metrics `deleting_pods_total`, `deleting_pods_error_total`
in Pod GC Controller.
For Attach Detach Controller, there's already a metric:
attachdetach_controller_forced_detaches
It is also useful to know how many nodes have taints. We can explore with [kube-state-metrics](https://github.com/kubernetes/kube-state-metrics) which generates metrics about the state of the objects.
`attachdetach_controller_forced_detaches`
There is also a `kube_node_spec_taint` in [kube-state-metrics](https://github.com/kubernetes/kube-state-metrics/blob/main/docs/node-metrics.md) that is a metric for the taint of a Kubernetes cluster node.
- [Optional] Aggregation method:
- Components exposing the metric:
- [X] Other (treat as last resort)
Expand Down
6 changes: 3 additions & 3 deletions keps/sig-storage/2268-non-graceful-shutdown/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,18 @@ see-also:
replaces:

# The target maturity stage in the current dev cycle for this KEP.
stage: beta
stage: stable

# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.26"
latest-milestone: "v1.28"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.24"
beta: "v1.26"
stable: "v1.27"
stable: "v1.28"

# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
Expand Down

0 comments on commit 6367497

Please sign in to comment.