-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multiple helm chart improvements #8103
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #8103 +/- ##
==========================================
- Coverage 42.20% 42.05% -0.16%
==========================================
Files 219 164 -55
Lines 12190 10913 -1277
Branches 179 0 -179
==========================================
- Hits 5145 4589 -556
+ Misses 6748 6064 -684
+ Partials 297 260 -37 |
@floreks i think so, i'll get it running my lab |
Fixes #8048
cert-manager
can be fully skipped now. Setcert-manager.enabled=false
andapp.ingress.issuer.scope=disabled
to fully disable it. Note thatsecretName
with the certificate must still be configured to point to the correct secret with a valid certificate.nginx
can be fully disabled. Setnginx.enabled=false
andapp.ingress.enabled=false
to fully disable it. Note that you have to provide a custom configuration that matches what we do with ingress otherwise, Dashboard will not work.nginx
configuration to useClusterIP
nginx service and custominternal-nginx
ingress class.NetworkPolicy
config to match correct ingress port namesTODO: