Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple helm chart improvements #8103

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Conversation

floreks
Copy link
Member

@floreks floreks commented Jul 21, 2023

Fixes #8048

  • cert-manager can be fully skipped now. Set cert-manager.enabled=false and app.ingress.issuer.scope=disabled to fully disable it. Note that secretName with the certificate must still be configured to point to the correct secret with a valid certificate.
  • nginx can be fully disabled. Set nginx.enabled=false and app.ingress.enabled=false to fully disable it. Note that you have to provide a custom configuration that matches what we do with ingress otherwise, Dashboard will not work.
  • updated default nginx configuration to use ClusterIP nginx service and custom internal-nginx ingress class.
  • updated NetworkPolicy config to match correct ingress port names
  • updated helm chart versioning to start with alpha. When releasing the helm chart we will remove previous "official" releases without alpha suffixes.

TODO:

  • Update documentation to cover new changes and inform users about our default configuration and that our dependencies can be replaced.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2023
@floreks floreks marked this pull request as draft July 21, 2023 11:01
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2023
@floreks
Copy link
Member Author

floreks commented Jul 21, 2023

@mlbiam does this cover everything mentioned in #8038 or did I miss anything?

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #8103 (806f600) into master (5d81c6f) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8103      +/-   ##
==========================================
- Coverage   42.20%   42.05%   -0.16%     
==========================================
  Files         219      164      -55     
  Lines       12190    10913    -1277     
  Branches      179        0     -179     
==========================================
- Hits         5145     4589     -556     
+ Misses       6748     6064     -684     
+ Partials      297      260      -37     

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 21, 2023
@mlbiam
Copy link
Contributor

mlbiam commented Jul 21, 2023

@floreks i think so, i'll get it running my lab

@floreks floreks changed the title wip: multiple helm chart improvements fix: multiple helm chart improvements Aug 18, 2023
@floreks floreks marked this pull request as ready for review August 18, 2023 10:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Helm] Chart updates
4 participants