Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-cli: add Eddie Zaneski as a co-chair #5322

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Nov 16, 2020

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2020
@soltysh
Copy link
Contributor Author

soltysh commented Nov 16, 2020

/hold
for visibility

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2020
@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Nov 16, 2020
@nikhita
Copy link
Member

nikhita commented Nov 16, 2020

@eddiezane congratulations!! 🎉 👏

Whenever you get a chance, please complete the Inclusive Leadership Training - https://training.linuxfoundation.org/training/inclusive-speaker-orientation/ 🙏

@sallyom
Copy link

sallyom commented Nov 16, 2020

thanks, @eddiezane for all that you do! 🥳 👍 🎉

@pwittrock
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2020
@seans3
Copy link
Contributor

seans3 commented Nov 16, 2020

/lgtm

@eddiezane
Copy link
Member

Thanks team! It's been incredible to learn from y'all and be a part of this community. Looking forward to continuing along and helping others grow as well.

@nikhita I have completed the training

@cblecker
Copy link
Member

/approve
/hold

Holding until lazy consensus achieved.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2020
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 23, 2020
@soltysh
Copy link
Contributor Author

soltysh commented Nov 23, 2020

The lazy consensus date has passed.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2020
@nikhita
Copy link
Member

nikhita commented Nov 23, 2020

Re-adding lgtm. Congrats, Eddie!! 🥳

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 043e232 into kubernetes:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants