-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Sig Governance Short Template #1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c4e3523
to
e97d841
Compare
71baeae
to
6d58a38
Compare
e5afb18
to
db9b7b5
Compare
LGTM, but I see you are still incorporating stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but will wait on others on before labeling.
@philips @timothysc Thanks! I updated the PR to include the new SIG Lead name (long live Coordinator!). I also refined / clarified some points that were implied but could be made more clear.
|
23ad236
to
c92af5d
Compare
- Resolve X-Subproject technical issues and decisions | ||
|
||
|
||
- Subproject Leads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be subproject owners, to be consistent with the contributor ladder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Done
|
||
[lazy-consensus]: http://communitymgt.wikia.com/wiki/Lazy_consensus | ||
[super-majority]: https://en.wikipedia.org/wiki/Supermajority#Two-thirds_vote | ||
[warnocks-dilemma]: http://communitymgt.wikia.com/wiki/Warnock%27s_Dilemma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These links look copied from the long template, with some not used and probably should be (eg: lazy consensus) and some not used and probably need removed (eg: warnocks dilemma and slo).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
c92af5d
to
40e1634
Compare
Addressed outstanding comments. Updated the SIG role names. |
40e1634
to
1a4a1bf
Compare
98a14ae
to
68658bf
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgrant0607, pwittrock The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is mostly replacing https://github.com/kubernetes/community/blob/master/... links with relative links, because relative links are easier to maintain. For example, if you rename a.md to b.md in a feature branch, updating an ../a.md to ../b.md target will work immediately (e.g. during pull-request review), while updating https://github.com/kubernetes/community/blob/master/a.md to https://github.com/kubernetes/community/blob/master/b.md will only work after your branch lands the rename in master. I'm not sure why the #L1454 fragment was part of the old sig-governance template sigs.yaml link, but it's been there since the template landed in 68658bf (Provide short template for SIG governance, 2018-02-23, kubernetes#1830). I've removed it in this commit. The Kubernetes Charter README link in the sig-governance template could just be: [Kubernetes Charter README]: README.md but I've sent it down to the project root and back to make life easier on new SIGs which copy/paste the file to a new location in this repository. With this commit they'll just need to drop one level of ../ to get the references working from places like sig-contributor-experience/charter.md. I've also chased a few files and anchors as they've moved around (e.g. the OBSOLETE_templates.md rename from 18958f8 (addressing Brians comments, 2017-09-06, kubernetes#1010) and the "and maintenance" header addition from f471f6b (Add new contact info for Paris and me, 2017-10-17, kubernetes#1215). This commit isn't complete, but it's a step in the right direction and all I had time for tonight ;).
This is mostly replacing https://github.com/kubernetes/community/blob/master/... links with relative links, because relative links are easier to maintain. For example, if you rename a.md to b.md in a feature branch, updating an ../a.md to ../b.md target will work immediately (e.g. during pull-request review), while updating https://github.com/kubernetes/community/blob/master/a.md to https://github.com/kubernetes/community/blob/master/b.md will only work after your branch lands the rename in master. I'm not sure why the #L1454 fragment was part of the old sig-governance template sigs.yaml link, but it's been there since the template landed in 68658bf (Provide short template for SIG governance, 2018-02-23, kubernetes#1830). I've removed it in this commit. The Kubernetes Charter README link in the sig-governance template could just be: [Kubernetes Charter README]: README.md but I've sent it down to the project root and back to make life easier on new SIGs which copy/paste the file to a new location in this repository. With this commit they'll just need to drop one level of ../ to get the references working from places like sig-contributor-experience/charter.md. I've also chased a few files and anchors as they've moved around, e.g. the OBSOLETE_templates.md rename from 18958f8 (addressing Brians comments, 2017-09-06, kubernetes#1010) and the "and maintenance" header addition from f471f6b (Add new contact info for Paris and me, 2017-10-17, This commit isn't complete, but it's a step in the right direction and all I had time for tonight ;).
This is mostly replacing https://github.com/kubernetes/community/blob/master/... links with relative links, because relative links are easier to maintain. For example, if you rename a.md to b.md in a feature branch, updating an ../a.md to ../b.md target will work immediately (e.g. during pull-request review), while updating https://github.com/kubernetes/community/blob/master/a.md to https://github.com/kubernetes/community/blob/master/b.md will only work after your branch lands the rename in master. I'm not sure why the #L1454 fragment was part of the old sig-governance template sigs.yaml link, but it's been there since the template landed in 68658bf (Provide short template for SIG governance, 2018-02-23, kubernetes#1830). I've removed it in this commit. The Kubernetes Charter README link in the sig-governance template could just be: [Kubernetes Charter README]: README.md but I've sent it down to the project root and back to make life easier on new SIGs which copy/paste the file to a new location in this repository. With this commit they'll just need to drop one level of ../ to get the references working from places like sig-contributor-experience/charter.md. I've also chased a few files and anchors as they've moved around, e.g. the OBSOLETE_templates.md rename from 18958f8 (addressing Brians comments, 2017-09-06, kubernetes#1010) and the "and maintenance" header addition from f471f6b (Add new contact info for Paris and me, 2017-10-17, This commit isn't complete, but it's a step in the right direction and all I had time for tonight ;).
This is mostly replacing https://github.com/kubernetes/community/blob/master/... links with relative links, because relative links are easier to maintain. For example, if you rename a.md to b.md in a feature branch, updating an /a.md to /b.md target will work immediately (e.g. during pull-request review), while updating https://github.com/kubernetes/community/blob/master/a.md to https://github.com/kubernetes/community/blob/master/b.md will only work after your branch lands the rename in master. I'm not sure why the #L1454 fragment was part of the old sig-governance template sigs.yaml link, but it's been there since the template landed in 68658bf (Provide short template for SIG governance, 2018-02-23, kubernetes#1830). I've removed it in this commit. The Kubernetes Charter README link in the sig-governance template could just be: [Kubernetes Charter README]: README.md but I've based it on the project root and back to make life easier on new SIGs which copy/paste the file to a new location in this repository. I personally prefer targets that use ../ for referencing other directories within a project, because those also work with generic Markdown tools (e.g. Emacs' Markdown mode). I've gone with /-rooted targets in this commit as requested in /sig-contributor-experience/markdown-link-style-guide.md. I've also chased a few files and anchors as they've moved around, e.g. the OBSOLETE_templates.md rename from 18958f8 (addressing Brians comments, 2017-09-06, kubernetes#1010) and the "and maintenance" header addition from f471f6b (Add new contact info for Paris and me, 2017-10-17, This commit isn't complete, but it's a step in the right direction and all I had time for tonight ;).
This is mostly replacing https://github.com/kubernetes/community/blob/master/... links with relative links, because relative links are easier to maintain. For example, if you rename a.md to b.md in a feature branch, updating an /a.md to /b.md target will work immediately (e.g. during pull-request review), while updating https://github.com/kubernetes/community/blob/master/a.md to https://github.com/kubernetes/community/blob/master/b.md will only work after your branch lands the rename in master. I'm not sure why the #L1454 fragment was part of the old sig-governance template sigs.yaml link, but it's been there since the template landed in 68658bf (Provide short template for SIG governance, 2018-02-23, kubernetes#1830). I've removed it in this commit. The Kubernetes Charter README link in the sig-governance template could just be: [Kubernetes Charter README]: README.md but I've based it on the project root and back to make life easier on new SIGs which copy/paste the file to a new location in this repository. I personally prefer targets that use ../ for referencing other directories within a project, because those also work with generic Markdown tools (e.g. Emacs' Markdown mode). I've gone with /-rooted targets in this commit as requested in /sig-contributor-experience/markdown-link-style-guide.md. I've also chased a few files and anchors as they've moved around, e.g. the OBSOLETE_templates.md rename from 18958f8 (addressing Brians comments, 2017-09-06, kubernetes#1010) and the "and maintenance" header addition from f471f6b (Add new contact info for Paris and me, 2017-10-17, This commit isn't complete, but it's a step in the right direction and all I had time for tonight ;).
This is mostly replacing https://github.com/kubernetes/community/blob/master/... links with relative links, because relative links are easier to maintain. For example, if you rename a.md to b.md in a feature branch, updating an /a.md to /b.md target will work immediately (e.g. during pull-request review), while updating https://github.com/kubernetes/community/blob/master/a.md to https://github.com/kubernetes/community/blob/master/b.md will only work after your branch lands the rename in master. I'm not sure why the #L1454 fragment was part of the old sig-governance template sigs.yaml link, but it's been there since the template landed in 68658bf (Provide short template for SIG governance, 2018-02-23, kubernetes#1830). I've removed it in this commit. The Kubernetes Charter README link in the sig-governance template could just be: [Kubernetes Charter README]: README.md but I've based it on the project root and back to make life easier on new SIGs which copy/paste the file to a new location in this repository. I personally prefer targets that use ../ for referencing other directories within a project, because those also work with generic Markdown tools (e.g. Emacs' Markdown mode). I've gone with /-rooted targets in this commit as requested in /sig-contributor-experience/markdown-link-style-guide.md. I've also chased a few files and anchors as they've moved around, e.g. the OBSOLETE_templates.md rename from 18958f8 (addressing Brians comments, 2017-09-06, kubernetes#1010) and the "and maintenance" header addition from f471f6b (Add new contact info for Paris and me, 2017-10-17, This commit isn't complete, but it's a step in the right direction and all I had time for tonight ;). The sig-list.md changes were generated automatically from the generator/list.tmpl changes with: $ make generate
This is mostly replacing https://github.com/kubernetes/community/blob/master/... links with relative links, because relative links are easier to maintain. For example, if you rename a.md to b.md in a feature branch, updating an /a.md to /b.md target will work immediately (e.g. during pull-request review), while updating https://github.com/kubernetes/community/blob/master/a.md to https://github.com/kubernetes/community/blob/master/b.md will only work after your branch lands the rename in master. I'm not sure why the #L1454 fragment was part of the old sig-governance template sigs.yaml link, but it's been there since the template landed in 68658bf (Provide short template for SIG governance, 2018-02-23, kubernetes#1830). I've removed it in this commit. The Kubernetes Charter README link in the sig-governance template could just be: [Kubernetes Charter README]: README.md but I've based it on the project root and back to make life easier on new SIGs which copy/paste the file to a new location in this repository. I personally prefer targets that use ../ for referencing other directories within a project, because those also work with generic Markdown tools (e.g. Emacs' Markdown mode). I've gone with /-rooted targets in this commit as requested in /sig-contributor-experience/markdown-link-style-guide.md. I've also chased a few files and anchors as they've moved around, e.g. the OBSOLETE_templates.md rename from 18958f8 (addressing Brians comments, 2017-09-06, kubernetes#1010) and the "and maintenance" header addition from f471f6b (Add new contact info for Paris and me, 2017-10-17, This commit isn't complete, but it's a step in the right direction and all I had time for tonight ;). The sig-list.md changes were generated automatically from the generator/list.tmpl changes with: $ make generate
This is mostly replacing https://github.com/kubernetes/community/blob/master/... links with relative links, because relative links are easier to maintain. For example, if you rename a.md to b.md in a feature branch, updating an /a.md to /b.md target will work immediately (e.g. during pull-request review), while updating https://github.com/kubernetes/community/blob/master/a.md to https://github.com/kubernetes/community/blob/master/b.md will only work after your branch lands the rename in master. I'm not sure why the #L1454 fragment was part of the old sig-governance template sigs.yaml link, but it's been there since the template landed in 68658bf (Provide short template for SIG governance, 2018-02-23, kubernetes#1830). I've removed it in this commit. The Kubernetes Charter README link in the sig-governance template could just be: [Kubernetes Charter README]: README.md but I've based it on the project root and back to make life easier on new SIGs which copy/paste the file to a new location in this repository. I personally prefer targets that use ../ for referencing other directories within a project, because those also work with generic Markdown tools (e.g. Emacs' Markdown mode). I've gone with /-rooted targets in this commit as requested in /sig-contributor-experience/markdown-link-style-guide.md. I've also chased a few files and anchors as they've moved around, e.g. the OBSOLETE_templates.md rename from 18958f8 (addressing Brians comments, 2017-09-06, kubernetes#1010) and the "and maintenance" header addition from f471f6b (Add new contact info for Paris and me, 2017-10-17, This commit isn't complete, but it's a step in the right direction and all I had time for tonight ;). The sig-list.md changes were generated automatically from the generator/list.tmpl changes with: $ make generate
Short template for sig governance
Also see:
Requirements PR: SIG Governance Requirements and Recommendations #1800Merged