Add design proposal for accelerator monitoring. #1420
Conversation
This was discussed on this doc: https://docs.google.com/document/d/13O4HNrB7QFpKQcLcJm28R-QBH3Xo0VmJ7w_Pkvmsf68/edit (accessible to anyone who is a member of kubernetes-dev or kubernetes-users Google Groups). This was presented during the sig-node meeting on 2017-10-10. Adding this to this repo, so it's more accessible.
k8s-ci-robot
added
size/L
|
/assign @vishh @derekwaynecarr |
k8s-github-robot
added
the
sig/node
|
|
||
| // Total acclerator memory. | ||
| // unit: bytes | ||
| MemoryTotal uint64 `json:"memory_total"` |
There was a problem hiding this comment.
nit: either fix the json tags (camel case) or remove them.
There was a problem hiding this comment.
This section is for what's added to cAdvisor which uses snake_case.
The following new metrics would be exposed per container from cAdvisor:
I mention below that we will add the same thing to the summary API.
We will update kubelet’s summary API to also add these metrics.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Let's wait for @derekwaynecarr to read through this before merging. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
There's a submit queue now that automatically merges LGTM'd PRs in this repo. I will send an update PR if Derek has any comments. |
|
@vishh @mindprince - no major concerns. thanks for getting this in the repo. |
For kubernetes/enhancements#369, google/cadvisor#1762 and kubernetes/kubernetes#55188
Conversion to markdown from Google doc: https://docs.google.com/document/d/13O4HNrB7QFpKQcLcJm28R-QBH3Xo0VmJ7w_Pkvmsf68/edit
(accessible to anyone who is a member of kubernetes-dev@ or kubernetes-users@ Google Groups). Lots of discussion on the doc which is hard to recreate here now.