Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cinder-csi-plugin] Cleanup: handle errors from GetDevicePath #1522

Merged
merged 1 commit into from
May 13, 2021
Merged

[cinder-csi-plugin] Cleanup: handle errors from GetDevicePath #1522

merged 1 commit into from
May 13, 2021

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented May 5, 2021

What this PR does / why we need it:
Now GetDevicePath from metadata doesn't return an error if something bad happens. This makes it difficult to debug Cinder CSI driver.

This commit modifies the function to return an error value, and also adds additional logging that should help with debugging.

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 5, 2021
@k8s-ci-robot k8s-ci-robot requested review from jichenjc and ricolin May 5, 2021 18:02
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 5, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented May 5, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 5, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 5, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 5, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 5, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 5, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 5, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 5, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 5, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 5, 2021

Build succeeded.

@Fedosin
Copy link
Contributor Author

Fedosin commented May 6, 2021

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 6, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 6, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 6, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 6, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 6, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 6, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 6, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 6, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 6, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 6, 2021

Build failed.

@Fedosin Fedosin force-pushed the no_metadata_error branch from 5392923 to 6d9d82f Compare May 6, 2021 15:29
@theopenlab-ci
Copy link

theopenlab-ci bot commented May 6, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 6, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 6, 2021

Build succeeded.

@k8s-ci-robot
Copy link
Contributor

@Fedosin: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-e2e-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 7, 2021

Build failed.

@Fedosin
[cinder-csi-plugin] Cleanup: handle errors from GetDevicePath
b0e686b 
Now GetDevicePath from metadata doesn't return an error if something
bad happens. This makes it difficult to debug Cinder CSI driver.

This commit modifies the function to return an error value, and also
adds additional loging that should help with debugging.
@Fedosin Fedosin force-pushed the no_metadata_error branch from 6d9d82f to b0e686b Compare May 8, 2021 16:38
@theopenlab-ci
Copy link

theopenlab-ci bot commented May 8, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 8, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 8, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 8, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 8, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 8, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 8, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 8, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 8, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 8, 2021

Build succeeded.

@Fedosin
Copy link
Contributor Author

Fedosin commented May 10, 2021

/test cloud-provider-openstack-acceptance-test-lb-octavia

@k8s-ci-robot
Copy link
Contributor

@Fedosin: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-lb-octavia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 10, 2021

Build failed.

@ramineni
Copy link
Contributor

/override openlab/cloud-provider-openstack-acceptance-test-lb-octavia

@k8s-ci-robot
Copy link
Contributor

@ramineni: Overrode contexts on behalf of ramineni: openlab/cloud-provider-openstack-acceptance-test-lb-octavia

In response to this:

/override openlab/cloud-provider-openstack-acceptance-test-lb-octavia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ramineni
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2021
ricolin
ricolin reviewed May 11, 2021
View reviewed changes
Copy link
Contributor

@ricolin ricolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jichenjc
Copy link
Contributor

/approve

thanks for the PR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit b7b31a6 into kubernetes:master May 13, 2021
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@Fedosin
[cinder-csi-plugin] Cleanup: handle errors from GetDevicePath (kubern…
f2af4f3 
…etes#1522)

Now GetDevicePath from metadata doesn't return an error if something
bad happens. This makes it difficult to debug Cinder CSI driver.

This commit modifies the function to return an error value, and also
adds additional loging that should help with debugging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayrus kayrus kayrus left review comments

@ricolin ricolin ricolin left review comments

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@ramineni ramineni

@ricolin ricolin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Fedosin @k8s-ci-robot @ramineni @jichenjc @kayrus @ricolin