Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump csi-provisioner to 2.1.0 #1366

Merged
merged 1 commit into from
Jan 19, 2021
Merged

bump csi-provisioner to 2.1.0 #1366

merged 1 commit into from
Jan 19, 2021

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Jan 12, 2021 •
edited
Loading

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #1362

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 12, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 12, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 12, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 12, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 12, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 12, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 12, 2021

Build failed.

@jichenjc jichenjc mentioned this pull request Jan 13, 2021
Closed
@ramineni
Copy link
Contributor

/test cloud-provider-openstack-acceptance-test-csi-cinder

@k8s-ci-robot
Copy link
Contributor

@ramineni: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-csi-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 13, 2021

Build succeeded.

@jichenjc
Copy link
Contributor Author

/retest

1 similar comment
@jichenjc
Copy link
Contributor Author

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 13, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 13, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 13, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 13, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 13, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 13, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 13, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 13, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 13, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 13, 2021

Build failed.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2021
@jichenjc
Copy link
Contributor Author

/retest

@jichenjc
Copy link
Contributor Author

@ramineni @lingxiankong please help to review, thanks

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 18, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 18, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 18, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 18, 2021

Build succeeded.

ramineni
ramineni reviewed Jan 18, 2021
View reviewed changes
docs/cinder-csi-plugin/features.md Outdated
@@ -13,6 +13,7 @@
- [Volume Cloning](#volume-cloning)
- [Multi-Attach Volumes](#multi-attach-volumes)
- [Liveness probe](#liveness-probe)
- [Set file type in provisioner](#set-file-type-in-provisioner)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesnt seem to be the right place. How about we add seperate heading "Sidecar Compatibility" before Supported Features here , https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/cinder-csi-plugin/using-cinder-csi-plugin.md#supported-features .

And add the current supported versions of sidecars and add this as note

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 18, 2021

Build succeeded.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2021
@jichenjc
Copy link
Contributor Author

@ramineni updated according to suggestions .. thanks

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 18, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 18, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 18, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 18, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 18, 2021

Build succeeded.

@lingxiankong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2021
@ramineni
Copy link
Contributor

Thanks for the update.
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramineni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit da85a2c into kubernetes:master Jan 19, 2021
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@jichenjc
bump csi-provisioner to 2.1.0 (kubernetes#1366)
4d9bd91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramineni ramineni ramineni left review comments

@chrigl chrigl Awaiting requested review from chrigl

Assignees

@lingxiankong lingxiankong

@ramineni ramineni

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cinder-csi-plugin] Cinder CSI Plugin doesn't honor anymore securityContext/fsGroup
4 participants
@jichenjc @ramineni @k8s-ci-robot @lingxiankong