Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop tagging latest for release branches #376

Merged
merged 1 commit into from
May 18, 2022

Conversation

hakman
Copy link
Member

@hakman hakman commented May 16, 2022

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
latest tag when pushing images to staging should only be applied on master branch

Which issue(s) this PR fixes:

n/a

Special notes for your reviewer:
n/a

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2022
@k8s-ci-robot k8s-ci-robot requested review from justinsb and wongma7 May 16, 2022 08:01
@hakman
Copy link
Member Author

hakman commented May 16, 2022

/triage accepted
/cc @olemarkus @nckturner

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 16, 2022
@hakman hakman force-pushed the stop_tagging_latest branch from 0d18912 to ad07269 Compare May 16, 2022 08:28
@hakman hakman changed the title Stop tagging latest for patch releases Stop tagging latest for release branches May 16, 2022
@hakman
Copy link
Member Author

hakman commented May 16, 2022

Commit wording was not great. Waiting for this to be merged first, before creating cherry-picks again.

@nckturner
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit 123e10c into kubernetes:release-1.23 May 18, 2022
k8s-ci-robot added a commit that referenced this pull request May 18, 2022
…tream-release-1.21

Automated cherry pick of #376: Stop tagging latest for release branches
k8s-ci-robot added a commit that referenced this pull request May 18, 2022
…tream-release-1.20

Automated cherry pick of #376: Stop tagging latest for release branches
k8s-ci-robot added a commit that referenced this pull request May 18, 2022
…tream-release-1.22

Automated cherry pick of #376: Stop tagging latest for release branches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants