E2E framework #304
E2E framework #304
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XXL
k8s-ci-robot
added
the
approved
nckturner
force-pushed
the
e2e-framework
branch
from
930ccbc to
04c310c
Compare
nckturner
force-pushed
the
e2e-framework
branch
2 times, most recently
from
276366c to
b0353e9
Compare
nckturner
force-pushed
the
e2e-framework
branch
from
bbf2ed6 to
952f23b
Compare
|
|
k8s-ci-robot
added
cncf-cla: no
nckturner
force-pushed
the
e2e-framework
branch
from
131aeab to
af05989
Compare
k8s-ci-robot
added
cncf-cla: yes
nckturner
force-pushed
the
e2e-framework
branch
from
af05989 to
e7daddb
Compare
| -v 2 \ | ||
| --up \ | ||
| --run-id=${test_run_id} \ | ||
| --cloud-provider=aws \ |
There was a problem hiding this comment.
need to build and deploy a ccm as built from the current PR
There was a problem hiding this comment.
The way kops solves this is to upload the image as file and sideload it. May be doable for CCM too.
There was a problem hiding this comment.
Spoke with @olemarkus about this possibility and it sound interesting, (especially when using the ECR kubelet image credential provider). He is going to do some exploratory work but in the meantime we will just push to ECR and expect an ECR repository to be present in the current account.
nckturner
force-pushed
the
e2e-framework
branch
4 times, most recently
from
6cdb3eb to
d0c3af7
Compare
hack/e2e/run.sh
Outdated
|
|
||
| echo "Building and pushing test driver image to ${IMAGE_NAME}:${IMAGE_TAG}" | ||
| aws ecr get-login-password --region "${REGION}" | docker login --username AWS --password-stdin "${AWS_ACCOUNT_ID}.dkr.ecr.${REGION}.amazonaws.com" | ||
| docker tag "${IMAGE}" "${IMAGE_NAME}:${IMAGE_TAG}" |
There was a problem hiding this comment.
is IMAGE expected to be an arg? no magic allowed, it should be defined at the top with other args
There was a problem hiding this comment.
might need some prefixes to disambiguate IMAGE from IMAGE_NAME and IMAGE_TAG... IMAGE is the image that is assumed t o exist, IMAGE_NAME:IMAGE_TAG is the destination to push it to
There was a problem hiding this comment.
Updated to use $MAKE_ prefix to differentiate variables passed from Makefile.
tests/e2e/testsuites/specs.go
Outdated
|
|
||
| //. "github.com/onsi/ginkgo" | ||
|
|
||
| type ServiceDetails struct { |
There was a problem hiding this comment.
I don't really understand the organization of these files
example_tester.go
specs.go
testsuites.go
plz shuffle them or add some comments explaining it
- Use ginkgo binary to run the tests for now instead of using the kops kubetest2 tester. We can improve this once we have the ability to run arbitrary e2e.test binaries with the kops tester.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adityavenneti, nckturner, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
…stream-release-1.22 Automated cherry pick of #304: E2E framework
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Add e2e test runner based on kubetest2.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Requires:
EDIT: this will be required in a future iteration, once we take full advantage of kubetest2.
Does this PR introduce a user-facing change?: