Adding instructions on how to use "dep" to get client-go v3.0.0-beta.0 in INSTALL.md #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
xiang90
reviewed
Apr 19, 2017
| $ dep ensure k8s.io/[email protected] | ||
| # Unfortunately dep doesn't interpret client-go/Godeps/Godeps.json, so you need | ||
| to manually checkout the compatible k8s.io/apimachinery version: | ||
| $ dep ensure k8s.io/apimachinery@75b8dd260ef0469d96d578705a87cffd0e09dab8 |
There was a problem hiding this comment.
i checked out 72e51762028fdf72f1a20e59bedceece02a425c6.
but i see errors like
scheme.AddDefaultingFuncs undefined (type *runtime.Scheme has no field or method AddDefaultingFuncs)
There was a problem hiding this comment.
also both apimachinery and master are broken.
There was a problem hiding this comment.
hmm... it seems working now after i got every deps flattened.
There was a problem hiding this comment.
Looks like dep doesn't remove nested "vendor" directories golang/dep#120
|
@caesarxuchao the changes look good to me. I like that you added "experimental" to the dep instructions :) |
ericchiang
reviewed
Apr 19, 2017
| # If you want to use client-go v3.0.0-beta.0: | ||
| $ dep ensure k8s.io/[email protected] | ||
| # Unfortunately dep doesn't interpret client-go/Godeps/Godeps.json, so you need | ||
| to manually checkout the compatible k8s.io/apimachinery version: |
| $ dep ensure k8s.io/[email protected] | ||
| # Unfortunately dep doesn't interpret client-go/Godeps/Godeps.json, so you need | ||
| to manually checkout the compatible k8s.io/apimachinery version: | ||
| $ dep ensure k8s.io/apimachinery@75b8dd260ef0469d96d578705a87cffd0e09dab8 |
There was a problem hiding this comment.
Looks like dep doesn't remove nested "vendor" directories golang/dep#120
mfojtik
pushed a commit
to mfojtik/client-go
that referenced
this pull request
Apr 11, 2022
bug 1949306: regenerate client-go for api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depdoesn't interpret Godeps.json, so we need to manually checkout the compatible version of apimachinery.I don't want to check in the manifest/lock files of
dep, as the format is not stable. In fact, the README of dep suggests not checking in these files.Alternative to this PR, perhaps we should remove
depfrom INSTALL.md until it becomes beta? @cscatolini @ericchiang @mbohlool @lavalamp what do you think?