glog terminates program when it can't create a logfile

[luxalpa]

This is quite a big deal when using with containerized read-only environments. We should absolutely get rid of glog as it just calls os.Exit(2) if it can't create a file, killing our entire process.

A workaround would be to do all calls to glog inside a seperate process, which shouldn't be worth the hassle.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[hjacobs]

/reopen

[k8s-ci-robot]

@hjacobs: you can't re-open an issue/PR unless you authored it or you are assigned to it.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[luxalpa]

/reopen

[hjacobs]

@destructive-dragon do you have any pointers for me where you (or someone else) applied a workaround to disable glog file writing? I want to fix kubernetes-sigs/external-dns#595 and I cannot use the command line flags for glog as External DNS uses kingpin for option parsing.

[luxalpa]

@hjacobs

You could either just try to fork the original glog and change the lines of code that do the Exit / require the files. This is a good starting point: https://github.com/golang/glog/blob/master/glog.go#L679

Or the way I solved it was to just reimplement all the glog functions and wrapped them straight onto a go-kit logger without all the complex Verbosity logic (see https://github.com/kubermatic/glog-gokit as an example)

See also: #18 (comment)

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[hjacobs]

/reopen

[k8s-ci-robot]

@hjacobs: you can't re-open an issue/PR unless you authored it or you are assigned to it.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hjacobs]

/remove-lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[hjacobs]

/remove-lifecycle stale

[hjacobs]

Fix for External DNS to replace glog with a sane version (for anybody interested): kubernetes-sigs/external-dns#714

[geekofalltrades]

There's a core Kubernetes issue open for this: kubernetes/kubernetes#61006

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[hjacobs]

/remove-lifecycle stale

Kubernetes core switched to k8s.io/klog apparently (kubernetes/kubernetes#61006 (comment))

[gjtempleton]

Looks like 74cd8bb has addressed this by switching to klog as of v10.0.0, though it's not called out in the Changelog.

[hjacobs]

@gjtempleton that would be awesome!

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[gjtempleton]

/remove-lifecycle rotten

Switching to klog doesn't fully resolve this, at least by default. (See: projectcalico/typha#258 and coredns/coredns#2529 )

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.