Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty ProviderID in ali NodeGroupForNode #6507

Merged
merged 4 commits into from
Mar 15, 2024
Merged

fix empty ProviderID in ali NodeGroupForNode #6507

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ae002d
check empty ProviderID in ali NodeGroupForNode
daimaxiaxie Feb 6, 2024
c01c10a
Merge branch 'kubernetes:master' into check-empty-id-in-ali-NodeGroup…
daimaxiaxie Feb 10, 2024
d061c45
Merge branch 'kubernetes:master' into check-empty-id-in-ali-NodeGroup…
daimaxiaxie Mar 2, 2024
e9d3d89
Merge branch 'kubernetes:master' into check-empty-id-in-ali-NodeGroup…
daimaxiaxie Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cluster-autoscaler/cloudprovider/alicloud/alicloud_cloud_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ func (ali *aliCloudProvider) NodeGroups() []cloudprovider.NodeGroup {

// NodeGroupForNode returns the node group for the given node.
func (ali *aliCloudProvider) NodeGroupForNode(node *apiv1.Node) (cloudprovider.NodeGroup, error) {
if len(node.Spec.ProviderID) == 0 {
klog.Warningf("Node %v has no providerId", node.Name)
return nil, nil
}
instanceId, err := ecsInstanceIdFromProviderId(node.Spec.ProviderID)
if err != nil {
klog.Errorf("failed to get instance Id from provider Id:%s,because of %s", node.Spec.ProviderID, err.Error())
Expand Down
Loading