[civo] Calculate real value for template using node group #6324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishal Anarse <[email protected]>
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vishalanarase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@vishalanarase addresses the failed test which is required to merge the PR. |
Signed-off-by: Vishal Anarse <[email protected]>
|
@Shubham82 I have updated the PR, I want this PR & previous PR to be merged into the next patch release. |
vishalanarase
changed the title
|
@Shubham82 It's clean run now |
@vishalanarase, Patch release was done for Nov month(#6293). |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Calculate the real value for template using node group
Special notes for your reviewer:
Calculate the real value for template using node group
Does this PR introduce a user-facing change?
NONE